From 00b11bda96c6c1d2d4ec49e68741f5ed038d5913 Mon Sep 17 00:00:00 2001
From: Brian Gough <brian.gough@overleaf.com>
Date: Wed, 1 Apr 2020 14:50:55 +0100
Subject: [PATCH] use separate loop for pendingUpdates metric

---
 .../document-updater/app/coffee/RealTimeRedisManager.coffee  | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/services/document-updater/app/coffee/RealTimeRedisManager.coffee b/services/document-updater/app/coffee/RealTimeRedisManager.coffee
index 6fd48033da..1bfa509078 100644
--- a/services/document-updater/app/coffee/RealTimeRedisManager.coffee
+++ b/services/document-updater/app/coffee/RealTimeRedisManager.coffee
@@ -21,6 +21,9 @@ module.exports = RealTimeRedisManager =
 		multi.exec (error, replys) ->
 			return callback(error) if error?
 			jsonUpdates = replys[0]
+			for jsonUpdate in jsonUpdates
+				# record metric for each update removed from queue
+				metrics.summary "redis.pendingUpdates", jsonUpdate.length, {status: "pop"}
 			updates = []
 			for jsonUpdate in jsonUpdates
 				try
@@ -28,8 +31,6 @@ module.exports = RealTimeRedisManager =
 				catch e
 					return callback e
 				updates.push update
-				# record metric for updates removed from queue
-				metrics.summary "redis.pendingUpdates", jsonUpdate.length, {status: "pop"}
 			callback error, updates
 
 	getUpdatesLength: (doc_id, callback)->