From 019562cb5a93e9d5c17760158057b8347714f6fc Mon Sep 17 00:00:00 2001 From: andrew rumble Date: Tue, 23 Jul 2024 10:53:47 +0100 Subject: [PATCH] Update promises to use async functions directly GitOrigin-RevId: f6a5d235ee259a4cf00f1e8d5c089b2d1d24a842 --- .../Project/ProjectEntityUpdateHandler.js | 45 +++++++++++-------- 1 file changed, 26 insertions(+), 19 deletions(-) diff --git a/services/web/app/src/Features/Project/ProjectEntityUpdateHandler.js b/services/web/app/src/Features/Project/ProjectEntityUpdateHandler.js index 24adcc3053..5ac1c435ee 100644 --- a/services/web/app/src/Features/Project/ProjectEntityUpdateHandler.js +++ b/services/web/app/src/Features/Project/ProjectEntityUpdateHandler.js @@ -21,7 +21,10 @@ const SafePath = require('./SafePath') const TpdsUpdateSender = require('../ThirdPartyDataStore/TpdsUpdateSender') const FileWriter = require('../../infrastructure/FileWriter') const EditorRealTimeController = require('../Editor/EditorRealTimeController') -const { promisifyAll } = require('@overleaf/promise-utils') +const { + callbackifyMultiResult, + callbackify, +} = require('@overleaf/promise-utils') const { iterablePaths } = require('./IterablePath') const LOCK_NAMESPACE = 'sequentialProjectStructureUpdateLock' @@ -1172,6 +1175,28 @@ const ProjectEntityUpdateHandler = { 'folder', ]), + promises: { + addDoc, + addDocWithRanges, + addFile, + addFolder, + convertDocToFile, + deleteEntity, + deleteEntityWithPath, + mkdirp, + mkdirpWithExactCase, + moveEntity, + renameEntity, + resyncProjectHistory, + setRootDoc, + unsetRootDoc, + updateDocLines, + upsertDoc, + upsertDocWithPath, + upsertFile, + upsertFileWithPath, + }, + async _addDocAndSendToTpds(projectId, folderId, doc) { let result, project try { @@ -1600,21 +1625,3 @@ function _listSubtree(entity, entityType, entityPath) { } module.exports = ProjectEntityUpdateHandler -module.exports.promises = promisifyAll(ProjectEntityUpdateHandler, { - without: ['isPathValidForRootDoc'], - multiResult: { - _addDocAndSendToTpds: ['result', 'project'], - addDoc: ['doc', 'folderId'], - addDocWithRanges: ['doc', 'folderId'], - _uploadFile: ['fileStoreUrl', 'fileRef'], - _addFileAndSendToTpds: ['result', 'project'], - addFile: ['fileRef', 'folderId'], - upsertDoc: ['doc', 'isNew'], - upsertFile: ['fileRef', 'isNew', 'oldFileRef'], - upsertDocWithPath: ['doc', 'isNew', 'newFolders', 'folder'], - upsertFileWithPath: ['fileRef', 'isNew', 'oldFile', 'newFolders', 'folder'], - mkdirp: ['newFolders', 'folder'], - mkdirpWithExactCase: ['newFolders', 'folder'], - addFolder: ['folder', 'parentFolderId'], - }, -})