[cm6] Improve alignment of review panel elements (#12710)

* Use a block widget for top padding
* Update review panel positions when the editor geometry changes
* Remove editorPaddingTop from position calculations
* Recalculate review panel on start adding comment
* Assert on line content rather than index
* Use broadcastChange
* Keep focus in the editor when opening the review panel
* debounce broadcastChange
* Set CULL_AFTER to Infinity

GitOrigin-RevId: a8d7b8967736a9164b5264eeaadf334c15ec95ce
This commit is contained in:
Alf Eaton
2023-04-25 08:05:02 +00:00
committed by Copybot
parent acf6abb0fb
commit 08ccdb79d3
6 changed files with 21 additions and 19 deletions
@@ -78,7 +78,10 @@ const EditorNavigationToolbarRoot = React.memo(
}, [chatIsOpen, setChatIsOpen, markMessagesAsRead])
const toggleReviewPanelOpen = useCallback(
() => setReviewPanelOpen(value => !value),
event => {
event.preventDefault()
setReviewPanelOpen(value => !value)
},
[setReviewPanelOpen]
)
@@ -11,7 +11,7 @@ function TrackChangesToggleButton({ trackChangesIsOpen, disabled, onClick }) {
return (
<div className="toolbar-item">
<button disabled={disabled} className={classes} onClick={onClick}>
<button disabled={disabled} className={classes} onMouseDown={onClick}>
<i className="review-icon" />
<p className="toolbar-label">{t('review')}</p>
</button>