From 0c53c3816e4d7608aaea3f96ec23d43ba9afac01 Mon Sep 17 00:00:00 2001 From: Alf Eaton Date: Mon, 22 Apr 2024 13:46:26 +0100 Subject: [PATCH] Remove latex-log-parser split test (#17999) GitOrigin-RevId: 5accb0e5fc4c1ecce563f1d6f991de8c8633308b --- .../src/Features/Project/ProjectController.js | 3 --- .../features/pdf-preview/util/output-files.js | 3 --- .../js/ide/log-parser/latex-log-parser.js | 17 +++-------------- 3 files changed, 3 insertions(+), 20 deletions(-) diff --git a/services/web/app/src/Features/Project/ProjectController.js b/services/web/app/src/Features/Project/ProjectController.js index 3f4ccdfb7a..e77df9f79d 100644 --- a/services/web/app/src/Features/Project/ProjectController.js +++ b/services/web/app/src/Features/Project/ProjectController.js @@ -553,9 +553,6 @@ const ProjectController = { pdfjsAssignment(cb) { SplitTestHandler.getAssignment(req, res, 'pdfjs-40', cb) }, - latexLogParserAssignment(cb) { - SplitTestHandler.getAssignment(req, res, 'latex-log-parser', cb) - }, trackPdfDownloadAssignment(cb) { SplitTestHandler.getAssignment(req, res, 'track-pdf-download', cb) }, diff --git a/services/web/frontend/js/features/pdf-preview/util/output-files.js b/services/web/frontend/js/features/pdf-preview/util/output-files.js index f74d040f79..0947c1d844 100644 --- a/services/web/frontend/js/features/pdf-preview/util/output-files.js +++ b/services/web/frontend/js/features/pdf-preview/util/output-files.js @@ -1,4 +1,3 @@ -import getMeta from '../../../utils/meta' import HumanReadableLogs from '../../../ide/human-readable-logs/HumanReadableLogs' import BibLogParser from '../../../ide/log-parser/bib-log-parser' import { enablePdfCaching } from './pdf-caching-flags' @@ -86,8 +85,6 @@ export const handleLogFiles = async (outputFiles, data, signal) => { result.log, { ignoreDuplicates: true, - oldRegexes: - getMeta('ol-splitTestVariants')?.['latex-log-parser'] !== 'new', } ) diff --git a/services/web/frontend/js/ide/log-parser/latex-log-parser.js b/services/web/frontend/js/ide/log-parser/latex-log-parser.js index 4fb5a03540..2a64340101 100644 --- a/services/web/frontend/js/ide/log-parser/latex-log-parser.js +++ b/services/web/frontend/js/ide/log-parser/latex-log-parser.js @@ -9,10 +9,6 @@ const LINES_REGEX = /lines? ([0-9]+)/ const PACKAGE_REGEX = /^(?:Package|Class|Module) (\b.+\b) Warning/ const FILE_LINE_ERROR_REGEX = /^([./].*):(\d+): (.*)/ -const LATEX_WARNING_REGEX_OLD = /^LaTeX Warning: (.*)$/ -const PACKAGE_WARNING_REGEX_OLD = /^(Package \b.+\b Warning:.*)$/ -const PACKAGE_REGEX_OLD = /^Package (\b.+\b) Warning/ - const STATE = { NORMAL: 0, ERROR: 1, @@ -27,16 +23,9 @@ export default class LatexParser { this.fileStack = [] this.currentFileList = this.rootFileList = [] this.openParens = 0 - // TODO: Needed only for beta release; remove when over. 20220530 - if (options.oldRegexes) { - this.latexWarningRegex = LATEX_WARNING_REGEX_OLD - this.packageWarningRegex = PACKAGE_WARNING_REGEX_OLD - this.packageRegex = PACKAGE_REGEX_OLD - } else { - this.latexWarningRegex = LATEX_WARNING_REGEX - this.packageWarningRegex = PACKAGE_WARNING_REGEX - this.packageRegex = PACKAGE_REGEX - } + this.latexWarningRegex = LATEX_WARNING_REGEX + this.packageWarningRegex = PACKAGE_WARNING_REGEX + this.packageRegex = PACKAGE_REGEX this.log = new LogText(text) }