From 0e2cf061db425d5ccec404a69885c10e87856465 Mon Sep 17 00:00:00 2001 From: Jakob Ackermann Date: Mon, 25 Apr 2022 10:17:57 +0100 Subject: [PATCH] Merge pull request #7548 from overleaf/jpa-login-instead [web] add "Log in instead" split test and click tracking in navbar GitOrigin-RevId: c3893540220292bdf44b30aa0c9fb2aacca2863a --- .../web/app/views/layout/navbar-marketing.pug | 18 ++++++++++++++++-- services/web/app/views/layout/navbar.pug | 18 ++++++++++++++++-- 2 files changed, 32 insertions(+), 4 deletions(-) diff --git a/services/web/app/views/layout/navbar-marketing.pug b/services/web/app/views/layout/navbar-marketing.pug index 9837634955..68cabda1fb 100644 --- a/services/web/app/views/layout/navbar-marketing.pug +++ b/services/web/app/views/layout/navbar-marketing.pug @@ -105,11 +105,25 @@ nav.navbar.navbar-default.navbar-main // register link if hasFeature('registration-page') li - a(href="/register") #{translate('register')} + a( + href="/register" + event-tracking="menu-clicked-register" + event-tracking-action="clicked" + event-tracking-trigger="click" + event-tracking-mb="true" + event-segmentation={ page: currentUrl } + ) #{translate('register')} // login link li - a(href="/login") #{translate('log_in')} + a( + href="/login" + event-tracking="menu-clicked-login" + event-tracking-action="clicked" + event-tracking-trigger="click" + event-tracking-mb="true" + event-segmentation={ page: currentUrl } + ) #{translate('log_in')} // projects link and account menu if getSessionUser() diff --git a/services/web/app/views/layout/navbar.pug b/services/web/app/views/layout/navbar.pug index 5e819bc53b..bb23ca4571 100644 --- a/services/web/app/views/layout/navbar.pug +++ b/services/web/app/views/layout/navbar.pug @@ -88,11 +88,25 @@ nav.navbar.navbar-default.navbar-main // register link if hasFeature('registration-page') li - a(href="/register") #{translate('register')} + a( + href="/register" + event-tracking="menu-clicked-register" + event-tracking-action="clicked" + event-tracking-trigger="click" + event-tracking-mb="true" + event-segmentation={ page: currentUrl } + ) #{translate('register')} // login link li - a(href="/login") #{translate('log_in')} + a( + href="/login" + event-tracking="menu-clicked-login" + event-tracking-action="clicked" + event-tracking-trigger="click" + event-tracking-mb="true" + event-segmentation={ page: currentUrl } + ) #{translate('log_in')} // projects link and account menu if getSessionUser()