From 0e6b455ab09458632eeb0e4b03ec203b569b5076 Mon Sep 17 00:00:00 2001
From: Eric Mc Sween <eric.mcsween@overleaf.com>
Date: Tue, 15 Oct 2019 09:10:21 -0400
Subject: [PATCH] Merge pull request #2194 from overleaf/ho-res-send-status

use sendStatus for status codes, prevents errors in logs

GitOrigin-RevId: 98613a3c894a01eb9112fa9472403caeeae45bc2
---
 .../web/app/src/Features/Analytics/AnalyticsController.js    | 4 ++--
 .../web/test/unit/src/Analytics/AnalyticsControllerTests.js  | 5 ++++-
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/services/web/app/src/Features/Analytics/AnalyticsController.js b/services/web/app/src/Features/Analytics/AnalyticsController.js
index a852c77d09..6d00c61772 100644
--- a/services/web/app/src/Features/Analytics/AnalyticsController.js
+++ b/services/web/app/src/Features/Analytics/AnalyticsController.js
@@ -69,10 +69,10 @@ module.exports = {
 var respondWith = function(error, res, next) {
   if (error instanceof Errors.ServiceNotConfiguredError) {
     // ignore, no-op
-    res.send(204)
+    res.sendStatus(204)
   } else if (error) {
     next(error)
   } else {
-    res.send(204)
+    res.sendStatus(204)
   }
 }
diff --git a/services/web/test/unit/src/Analytics/AnalyticsControllerTests.js b/services/web/test/unit/src/Analytics/AnalyticsControllerTests.js
index 982140a215..9d2a2cad4e 100644
--- a/services/web/test/unit/src/Analytics/AnalyticsControllerTests.js
+++ b/services/web/test/unit/src/Analytics/AnalyticsControllerTests.js
@@ -37,7 +37,10 @@ describe('AnalyticsController', function() {
       }
     })
 
-    this.res = { send() {} }
+    this.res = {
+      send() {},
+      sendStatus() {}
+    }
   })
 
   describe('updateEditingSession', function() {