From 11d8b5162edaf89734a38f0ff1678a398853d040 Mon Sep 17 00:00:00 2001
From: Tim Down <158919+timdown@users.noreply.github.com>
Date: Tue, 3 Sep 2024 12:33:08 +0100
Subject: [PATCH] Merge pull request #20237 from
 overleaf/td-bs5-contact-nav-item-button

Implement contact form nav item as a button rather than link

GitOrigin-RevId: 00690f70d343077b7884005f2e4ab8f8cc651b23
---
 .../bootstrap-5/navbar/contact-us-item.tsx    | 24 +++++++++++--------
 1 file changed, 14 insertions(+), 10 deletions(-)

diff --git a/services/web/frontend/js/features/ui/components/bootstrap-5/navbar/contact-us-item.tsx b/services/web/frontend/js/features/ui/components/bootstrap-5/navbar/contact-us-item.tsx
index 49fcfcfd59..180c57b252 100644
--- a/services/web/frontend/js/features/ui/components/bootstrap-5/navbar/contact-us-item.tsx
+++ b/services/web/frontend/js/features/ui/components/bootstrap-5/navbar/contact-us-item.tsx
@@ -1,6 +1,7 @@
-import NavDropdownLinkItem from '@/features/ui/components/bootstrap-5/navbar/nav-dropdown-link-item'
 import { sendMB } from '@/infrastructure/event-tracking'
 import { useTranslation } from 'react-i18next'
+import { DropdownItem } from 'react-bootstrap-5'
+import NavDropdownItem from '@/features/ui/components/bootstrap-5/navbar/nav-dropdown-item'
 
 export default function ContactUsItem({
   showModal,
@@ -10,14 +11,17 @@ export default function ContactUsItem({
   const { t } = useTranslation()
 
   return (
-    <NavDropdownLinkItem
-      href="#"
-      onClick={() => {
-        sendMB('menu-clicked-contact')
-        showModal()
-      }}
-    >
-      {t('contact_us')}
-    </NavDropdownLinkItem>
+    <NavDropdownItem>
+      <DropdownItem
+        as="button"
+        role="menuitem"
+        onClick={() => {
+          sendMB('menu-clicked-contact')
+          showModal()
+        }}
+      >
+        {t('contact_us')}
+      </DropdownItem>
+    </NavDropdownItem>
   )
 }