Merge pull request #5367 from overleaf/jpa-node-handle-callback-err

[misc] fix eslint violations for node/handle-callback-err

GitOrigin-RevId: 83a4900e8861010df1917bff49382bd9c93375bd

services/chat/test/acceptance/js/GettingMessagesTests.js

@@ -1,5 +1,4 @@
 /* eslint-disable
-    handle-callback-err,
     max-len,
     no-unused-vars,
 */
@@ -55,6 +54,7 @@ describe('Getting messages', function () {
       return ChatClient.getGlobalMessages(
         this.project_id,
         (error, response, messages) => {
+          if (error) return done(error)
           expect(messages.length).to.equal(2)
           messages.reverse()
           expect(messages[0].content).to.equal(this.content1)
@@ -115,6 +115,7 @@ describe('Getting messages', function () {
       return ChatClient.getThreads(
         this.project_id,
         (error, response, threads) => {
+          if (error) return done(error)
           expect(Object.keys(threads).length).to.equal(2)
           const thread1 = threads[this.thread_id1]
           expect(thread1.messages.length).to.equal(2)

services/chat/test/acceptance/js/SendingAMessageTests.js

@@ -1,5 +1,4 @@
 /* eslint-disable
-    handle-callback-err,
     max-len,
     no-return-assign,
     node/no-deprecated-api,
@@ -121,6 +120,7 @@ describe('Sending a message', function () {
           'malformed-user',
           'content',
           (error, response, body) => {
+            if (error) return done(error)
             expect(response.statusCode).to.equal(400)
             expect(body).to.equal('Invalid user_id')
             return done()
@@ -137,6 +137,7 @@ describe('Sending a message', function () {
           this.user_id,
           'content',
           (error, response, body) => {
+            if (error) return done(error)
             expect(response.statusCode).to.equal(400)
             expect(body).to.equal('Invalid project_id')
             return done()
@@ -153,6 +154,7 @@ describe('Sending a message', function () {
           this.user_id,
           'content',
           (error, response, body) => {
+            if (error) return done(error)
             expect(response.statusCode).to.equal(400)
             expect(body).to.equal('Invalid thread_id')
             return done()
@@ -169,6 +171,7 @@ describe('Sending a message', function () {
           this.user_id,
           null,
           (error, response, body) => {
+            if (error) return done(error)
             expect(response.statusCode).to.equal(400)
             expect(body).to.equal('No content provided')
             return done()
@@ -186,6 +189,7 @@ describe('Sending a message', function () {
           this.user_id,
           content,
           (error, response, body) => {
+            if (error) return done(error)
             expect(response.statusCode).to.equal(400)
             expect(body).to.equal('Content too long (> 10240 bytes)')
             return done()

services/chat/test/acceptance/js/helpers/ChatApp.js

@@ -1,6 +1,3 @@
-/* eslint-disable
-    handle-callback-err,
-*/
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.
 /*
@@ -20,7 +17,7 @@ module.exports = {
   callbacks: [],
   ensureRunning(callback) {
     if (callback == null) {
-      callback = function (error) {}
+      callback = function () {}
     }
     if (this.running) {
       return callback()