From 19e1d50e2e384e143d6b212e8f1a976fb4fa4316 Mon Sep 17 00:00:00 2001 From: M Fahru Date: Tue, 10 Jan 2023 11:22:03 -0700 Subject: [PATCH] Fix editor overleaf logo on editor disappears if menu button is pressed in light theme GitOrigin-RevId: a4f104cf988bfc267ba70cbe546e150bea773691 --- services/web/frontend/stylesheets/app/editor/toolbar.less | 3 +++ services/web/frontend/stylesheets/core/ol-light-variables.less | 2 ++ services/web/frontend/stylesheets/core/variables.less | 2 ++ services/web/frontend/stylesheets/variables/all.less | 2 ++ services/web/frontend/stylesheets/variables/themes/light.less | 2 ++ 5 files changed, 11 insertions(+) diff --git a/services/web/frontend/stylesheets/app/editor/toolbar.less b/services/web/frontend/stylesheets/app/editor/toolbar.less index b157cb2566..1847107cb0 100644 --- a/services/web/frontend/stylesheets/app/editor/toolbar.less +++ b/services/web/frontend/stylesheets/app/editor/toolbar.less @@ -93,6 +93,9 @@ color: @toolbar-btn-active-color; background-color: @toolbar-btn-active-bg-color; box-shadow: @toolbar-btn-active-shadow; + .editor-menu-icon { + background: @editor-header-logo-background-active; + } } .label { top: 4px; diff --git a/services/web/frontend/stylesheets/core/ol-light-variables.less b/services/web/frontend/stylesheets/core/ol-light-variables.less index 32041d8644..826526bdaf 100644 --- a/services/web/frontend/stylesheets/core/ol-light-variables.less +++ b/services/web/frontend/stylesheets/core/ol-light-variables.less @@ -77,6 +77,8 @@ @toolbar-icon-btn-hover-color: @ol-blue-gray-3; @editor-header-logo-background: url(../../../public/img/ol-brand/overleaf-o.svg) center / contain no-repeat; +@editor-header-logo-background-active: url(../../../public/img/ol-brand/overleaf-o-white.svg) + center / contain no-repeat; @project-name-color: @ol-blue-gray-3; @project-rename-link-color: @ol-blue-gray-3; @project-rename-link-color-hover: @ol-blue-gray-4; diff --git a/services/web/frontend/stylesheets/core/variables.less b/services/web/frontend/stylesheets/core/variables.less index eb17713e3d..e844347872 100644 --- a/services/web/frontend/stylesheets/core/variables.less +++ b/services/web/frontend/stylesheets/core/variables.less @@ -58,6 +58,8 @@ @editor-header-logo-background: url(../../../public/img/ol-brand/overleaf-o-white.svg) center / contain no-repeat; +@editor-header-logo-background-active: url(../../../public/img/ol-brand/overleaf-o-white.svg) + center / contain no-repeat; @editor-loading-logo-padding-top: 115.44%; @editor-loading-logo-background-url: url(../../../public/img/ol-brand/overleaf-o-grey.svg); @editor-loading-logo-foreground-url: url(../../../public/img/ol-brand/overleaf-o.svg); diff --git a/services/web/frontend/stylesheets/variables/all.less b/services/web/frontend/stylesheets/variables/all.less index f1c12abd52..036f474160 100644 --- a/services/web/frontend/stylesheets/variables/all.less +++ b/services/web/frontend/stylesheets/variables/all.less @@ -6,6 +6,8 @@ @editor-header-logo-background: url(../../../public/img/ol-brand/overleaf-o-white.svg) center / contain no-repeat; +@editor-header-logo-background-active: url(../../../public/img/ol-brand/overleaf-o-white.svg) + center / contain no-repeat; @editor-loading-logo-padding-top: 115.44%; @editor-loading-logo-background-url: url(../../../public/img/ol-brand/overleaf-o-grey.svg); @editor-loading-logo-foreground-url: url(../../../public/img/ol-brand/overleaf-o.svg); diff --git a/services/web/frontend/stylesheets/variables/themes/light.less b/services/web/frontend/stylesheets/variables/themes/light.less index 6a36a479a7..a261c48696 100644 --- a/services/web/frontend/stylesheets/variables/themes/light.less +++ b/services/web/frontend/stylesheets/variables/themes/light.less @@ -66,6 +66,8 @@ @toolbar-icon-btn-hover-color: @neutral-70; @editor-header-logo-background: url(../../../../public/img/ol-brand/overleaf-o.svg) center / contain no-repeat; +@editor-header-logo-background-active: url(../../../../public/img/ol-brand/overleaf-o-white.svg) + center / contain no-repeat; @project-name-color: @neutral-70; @project-rename-link-color: @neutral-70; @project-rename-link-color-hover: @neutral-70;