From 1c62f82f9c36fee4affe6703c081e666d2734d48 Mon Sep 17 00:00:00 2001 From: Jessica Lawshe Date: Thu, 24 Feb 2022 08:43:37 -0600 Subject: [PATCH] Merge pull request #6886 from overleaf/jpa-less-verbose-ci [web] skip HIBP check for all tests but the HIBP specific ones GitOrigin-RevId: 714e69cc2220e7edcef875d6be487ded571cd977 --- .../web/test/acceptance/config/settings.test.defaults.js | 2 +- .../web/test/acceptance/src/HaveIBeenPwnedApiTests.js | 8 ++++++++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/services/web/test/acceptance/config/settings.test.defaults.js b/services/web/test/acceptance/config/settings.test.defaults.js index a65a02d1ab..da0c909e99 100644 --- a/services/web/test/acceptance/config/settings.test.defaults.js +++ b/services/web/test/acceptance/config/settings.test.defaults.js @@ -35,7 +35,7 @@ module.exports = { }, haveIBeenPwned: { - enabled: true, + enabled: false, url: 'http://localhost:1337', }, }, diff --git a/services/web/test/acceptance/src/HaveIBeenPwnedApiTests.js b/services/web/test/acceptance/src/HaveIBeenPwnedApiTests.js index d65c2aa807..a0dee05d3c 100644 --- a/services/web/test/acceptance/src/HaveIBeenPwnedApiTests.js +++ b/services/web/test/acceptance/src/HaveIBeenPwnedApiTests.js @@ -1,3 +1,4 @@ +const Settings = require('@overleaf/settings') const { expect } = require('chai') const User = require('./helpers/User').promises const MockHaveIBeenPwnedApiClass = require('./mocks/MockHaveIBeenPwnedApi') @@ -60,6 +61,13 @@ async function resetPassword(password) { } describe('HaveIBeenPwnedApi', function () { + before(function () { + Settings.apis.haveIBeenPwned.enabled = true + }) + after(function () { + Settings.apis.haveIBeenPwned.enabled = false + }) + describe('login with weak password', function () { beforeEach(function () { user = new User()