From 1ed1eaaa052a04a727771a51429ad9313e1d2385 Mon Sep 17 00:00:00 2001
From: Shane Kilkelly <shane@kilkelly.me>
Date: Tue, 21 Mar 2017 10:57:39 +0000
Subject: [PATCH] If analytics is not configured, produce a
 ServiceNotConfiguredError

---
 .../coffee/Features/Analytics/AnalyticsController.coffee | 9 ++++++++-
 .../coffee/Features/Analytics/AnalyticsManager.coffee    | 4 ++--
 2 files changed, 10 insertions(+), 3 deletions(-)

diff --git a/services/web/app/coffee/Features/Analytics/AnalyticsController.coffee b/services/web/app/coffee/Features/Analytics/AnalyticsController.coffee
index f9431a0f5c..75a8bf092a 100644
--- a/services/web/app/coffee/Features/Analytics/AnalyticsController.coffee
+++ b/services/web/app/coffee/Features/Analytics/AnalyticsController.coffee
@@ -1,7 +1,14 @@
 AnalyticsManager = require "./AnalyticsManager"
+Errors = require "../Errors/Errors"
+
 
 module.exports = AnalyticsController =
 	recordEvent: (req, res, next) ->
 		AnalyticsManager.recordEvent req.session?.user?._id, req.params.event, req.body, (error) ->
-			return next(error) if error?
+			if error?
+				if error instanceof Errors.ServiceNotConfiguredError
+					# ignore, no-op
+					return next(204)
+				else
+					return next(error)
 			res.send 204
diff --git a/services/web/app/coffee/Features/Analytics/AnalyticsManager.coffee b/services/web/app/coffee/Features/Analytics/AnalyticsManager.coffee
index 9f34d6d9d1..66d2818032 100644
--- a/services/web/app/coffee/Features/Analytics/AnalyticsManager.coffee
+++ b/services/web/app/coffee/Features/Analytics/AnalyticsManager.coffee
@@ -2,6 +2,7 @@ settings = require "settings-sharelatex"
 logger = require "logger-sharelatex"
 _ = require "underscore"
 request = require "request"
+Errors = require '../Errors/Errors'
 
 
 makeRequest = (opts, callback)->
@@ -10,8 +11,7 @@ makeRequest = (opts, callback)->
 		opts.url = "#{settings.apis.analytics.url}#{urlPath}"
 		request opts, callback
 	else
-		callback()
-
+		callback(new Errors.ServiceNotConfiguredError('Analytics service not configured'))
 
 
 module.exports =