From 221acb8207b62079e19c4fca29815b8bb90db43b Mon Sep 17 00:00:00 2001 From: Alasdair Smith Date: Mon, 5 Nov 2018 14:01:02 +0000 Subject: [PATCH] Merge pull request #1111 from sharelatex/as-fix-spell-check Fix bug where read only editor would crash GitOrigin-RevId: ed8ac8ddcec118b57e20916afaddb50d5062b2cf --- services/web/public/src/ide/editor/directives/aceEditor.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/services/web/public/src/ide/editor/directives/aceEditor.js b/services/web/public/src/ide/editor/directives/aceEditor.js index ded1dd03c0..99f30ae5ff 100644 --- a/services/web/public/src/ide/editor/directives/aceEditor.js +++ b/services/web/public/src/ide/editor/directives/aceEditor.js @@ -594,6 +594,7 @@ define([ } const initSpellCheck = function() { + if (!spellCheckManager) return spellCheckManager.init() editor.on('changeSession', onSessionChangeForSpellCheck) onSessionChangeForSpellCheck({ session: editor.getSession() }) // Force initial setup @@ -601,6 +602,7 @@ define([ } const tearDownSpellCheck = function() { + if (!spellCheckManager) return editor.off('changeSession', onSessionChangeForSpellCheck) return editor.off( 'nativecontextmenu',