Merge pull request #5705 from overleaf/jpa-node-14

[misc] upgrade node version from 12 to 14

GitOrigin-RevId: 15c465c7bb5e42b0c71e2dedb09cf4fe9f1d8ec6

services/filestore/.nvmrc

@@ -1 +1 @@
-12.22.7
+14.18.1

services/filestore/Dockerfile

@@ -2,7 +2,7 @@
 # Instead run bin/update_build_scripts from
 # https://github.com/sharelatex/sharelatex-dev-environment
 
-FROM node:12.22.7 as base
+FROM node:14.18.1 as base
 
 WORKDIR /app
 COPY install_deps.sh /app

services/filestore/app/js/FileHandler.js

@@ -143,6 +143,9 @@ async function _getConvertedFileAndCache(bucket, key, convertedKey, opts) {
   // S3 provides eventual consistency for read-after-write.""
   // https://docs.aws.amazon.com/AmazonS3/latest/dev/Introduction.html#ConsistencyModel
   const readStream = fs.createReadStream(convertedFsPath)
+  readStream.on('error', function () {
+    LocalFileWriter.deleteFile(convertedFsPath, function () {})
+  })
   readStream.on('end', function () {
     LocalFileWriter.deleteFile(convertedFsPath, function () {})
   })

services/filestore/buildscript.txt

@@ -4,6 +4,6 @@ filestore
 --docker-repos=gcr.io/overleaf-ops
 --env-add=ENABLE_CONVERSIONS="true",USE_PROM_METRICS="true",AWS_S3_USER_FILES_BUCKET_NAME=fake_user_files,AWS_S3_TEMPLATE_FILES_BUCKET_NAME=fake_template_files,AWS_S3_PUBLIC_FILES_BUCKET_NAME=fake_public_files,GCS_USER_FILES_BUCKET_NAME=fake_userfiles,GCS_TEMPLATE_FILES_BUCKET_NAME=fake_templatefiles,GCS_PUBLIC_FILES_BUCKET_NAME=fake_publicfiles
 --env-pass-through=
---node-version=12.22.7
+--node-version=14.18.1
 --public-repo=True
 --script-version=3.11.0