From 22a5d5bd80a28f0ff94966faf981141e2197da0f Mon Sep 17 00:00:00 2001 From: Jakob Ackermann Date: Tue, 13 Jul 2021 12:21:13 +0100 Subject: [PATCH] [misc] temporary override a few new/changed eslint rules --- services/docstore/.eslintrc | 15 ++++++++++++++- services/docstore/app/js/DocManager.js | 1 - services/docstore/app/js/HealthChecker.js | 1 - 3 files changed, 14 insertions(+), 3 deletions(-) diff --git a/services/docstore/.eslintrc b/services/docstore/.eslintrc index 1c14f50efe..a97661b15f 100644 --- a/services/docstore/.eslintrc +++ b/services/docstore/.eslintrc @@ -5,7 +5,7 @@ "extends": [ "eslint:recommended", "standard", - "prettier", + "prettier" ], "parserOptions": { "ecmaVersion": 2018 @@ -20,6 +20,19 @@ "mocha": true }, "rules": { + // TODO(das7pad): remove overrides after fixing all the violations manually (https://github.com/overleaf/issues/issues/3882#issuecomment-878999671) + // START of temporary overrides + "array-callback-return": "off", + "no-dupe-else-if": "off", + "no-var": "off", + "no-empty": "off", + "node/handle-callback-err": "off", + "no-loss-of-precision": "off", + "node/no-callback-literal": "off", + "node/no-path-concat": "off", + "prefer-regex-literals": "off", + // END of temporary overrides + // Swap the no-unused-expressions rule with a more chai-friendly one "no-unused-expressions": 0, "chai-friendly/no-unused-expressions": "error", diff --git a/services/docstore/app/js/DocManager.js b/services/docstore/app/js/DocManager.js index 0f00ce79cf..51a974d5a7 100644 --- a/services/docstore/app/js/DocManager.js +++ b/services/docstore/app/js/DocManager.js @@ -3,7 +3,6 @@ handle-callback-err, no-dupe-keys, no-undef, - standard/no-callback-literal, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/docstore/app/js/HealthChecker.js b/services/docstore/app/js/HealthChecker.js index 3271c40164..5578afff75 100644 --- a/services/docstore/app/js/HealthChecker.js +++ b/services/docstore/app/js/HealthChecker.js @@ -1,6 +1,5 @@ /* eslint-disable camelcase, - standard/no-callback-literal, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint.