From 24e2fdaab5be025d94ea358a8565bee665340bc9 Mon Sep 17 00:00:00 2001 From: Pierpaolo Vittorini Date: Tue, 30 Jun 2026 11:43:07 +0200 Subject: [PATCH] Admin tools, Authentication: Fix: set analyticsId when creating a new user --- services/web/modules/admin-tools/app/src/UserListController.mjs | 1 + .../authentication/ldap/app/src/LDAPAuthenticationManager.mjs | 2 ++ .../authentication/oidc/app/src/OIDCAuthenticationManager.mjs | 2 ++ .../authentication/saml/app/src/SAMLAuthenticationManager.mjs | 2 ++ 4 files changed, 7 insertions(+) diff --git a/services/web/modules/admin-tools/app/src/UserListController.mjs b/services/web/modules/admin-tools/app/src/UserListController.mjs index 101cd82dc8..7fd65881b8 100644 --- a/services/web/modules/admin-tools/app/src/UserListController.mjs +++ b/services/web/modules/admin-tools/app/src/UserListController.mjs @@ -116,6 +116,7 @@ async function registerNewUser(req, res, next) { } delete req.body.isExternal req.body.password = crypto.randomBytes(32).toString('hex') + req.body.analyticsId = crypto.randomUUID() let user try { diff --git a/services/web/modules/authentication/ldap/app/src/LDAPAuthenticationManager.mjs b/services/web/modules/authentication/ldap/app/src/LDAPAuthenticationManager.mjs index 25947de148..003d076870 100644 --- a/services/web/modules/authentication/ldap/app/src/LDAPAuthenticationManager.mjs +++ b/services/web/modules/authentication/ldap/app/src/LDAPAuthenticationManager.mjs @@ -1,3 +1,4 @@ +import crypto from 'node:crypto' import Settings from '@overleaf/settings' import UserCreator from '../../../../../app/src/Features/User/UserCreator.mjs' import { ParallelLoginError } from '../../../../../app/src/Features/Authentication/AuthenticationErrors.mjs' @@ -42,6 +43,7 @@ const LDAPAuthenticationManager = { last_name: lastName, isAdmin: isAdmin, holdingAccount: false, + analyticsId: crypto.randomUUID(), } ) await User.updateOne( diff --git a/services/web/modules/authentication/oidc/app/src/OIDCAuthenticationManager.mjs b/services/web/modules/authentication/oidc/app/src/OIDCAuthenticationManager.mjs index a6cecd3b54..1cd0baf2ea 100644 --- a/services/web/modules/authentication/oidc/app/src/OIDCAuthenticationManager.mjs +++ b/services/web/modules/authentication/oidc/app/src/OIDCAuthenticationManager.mjs @@ -1,3 +1,4 @@ +import crypto from 'node:crypto' import Settings from '@overleaf/settings' import UserCreator from '../../../../../app/src/Features/User/UserCreator.mjs' import ThirdPartyIdentityManager from '../../../../../app/src/Features/User/ThirdPartyIdentityManager.mjs' @@ -58,6 +59,7 @@ const OIDCAuthenticationManager = { last_name: lastName, isAdmin: isAdmin, holdingAccount: false, + analyticsId: crypto.randomUUID(), } ) } diff --git a/services/web/modules/authentication/saml/app/src/SAMLAuthenticationManager.mjs b/services/web/modules/authentication/saml/app/src/SAMLAuthenticationManager.mjs index 40947971a8..8be0666447 100644 --- a/services/web/modules/authentication/saml/app/src/SAMLAuthenticationManager.mjs +++ b/services/web/modules/authentication/saml/app/src/SAMLAuthenticationManager.mjs @@ -1,3 +1,4 @@ +import crypto from 'node:crypto' import Settings from '@overleaf/settings' import UserCreator from '../../../../../app/src/Features/User/UserCreator.mjs' import { ParallelLoginError } from '../../../../../app/src/Features/Authentication/AuthenticationErrors.mjs' @@ -43,6 +44,7 @@ const SAMLAuthenticationManager = { isAdmin: isAdmin, holdingAccount: false, samlIdentifiers: [{ providerId: providerId }], + analyticsId: crypto.randomUUID(), } ) }