agw/overleaf-cep
1
0
Fork 0
mirror of https://github.com/yu-i-i/overleaf-cep.git synced 2026-05-28 03:21:56 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2998 from overleaf/as-beta-page-updates

Browse Source 
Update beta program page to include feedback survey link

GitOrigin-RevId: 549cd2be01b8f64d952d0347c8c102d0d2efae24
This commit is contained in:
Alasdair Smith
2020-07-14 14:24:25 +01:00
committed by Copybot
parent d4d6e2c45d
commit 2556fded1e
4 changed files with 66 additions and 97 deletions
Download Patch File Download Diff File Expand all files Collapse all files

75
services/web/test/unit/src/BetaProgram/BetaProgramControllerTests.js
View File

@@ -1,26 +1,12 @@
/* eslint-disable
max-len,
mocha/no-identical-title,
no-return-assign,
no-unused-vars,
*/
// TODO: This file was created by bulk-decaffeinate.
// Fix any style issues and re-enable lint.
/*
* decaffeinate suggestions:
* DS102: Remove unnecessary code created because of implicit returns
* Full docs: https://github.com/decaffeinate/decaffeinate/blob/master/docs/suggestions.md
*/
const should = require('chai').should()
require('chai').should()
const SandboxedModule = require('sandboxed-module')
const assert = require('assert')
const path = require('path')
const sinon = require('sinon')
const modulePath = path.join(
__dirname,
'../../../../app/src/Features/BetaProgram/BetaProgramController'
)
const { expect } = require('chai')
describe('BetaProgramController', function() {
beforeEach(function() {
@@ -67,130 +53,113 @@ describe('BetaProgramController', function() {
redirect: sinon.stub(),
render: sinon.stub()
}
return (this.next = sinon.stub())
this.next = sinon.stub()
})
describe('optIn', function() {
beforeEach(function() {
return this.BetaProgramHandler.optIn.callsArgWith(1, null)
this.BetaProgramHandler.optIn.callsArgWith(1, null)
})
it("should redirect to '/beta/participate'", function() {
this.BetaProgramController.optIn(this.req, this.res, this.next)
this.res.redirect.callCount.should.equal(1)
return this.res.redirect.firstCall.args[0].should.equal(
'/beta/participate'
)
this.res.redirect.firstCall.args[0].should.equal('/beta/participate')
})
it('should not call next with an error', function() {
this.BetaProgramController.optIn(this.req, this.res, this.next)
return this.next.callCount.should.equal(0)
})
it('should not call next with an error', function() {
this.BetaProgramController.optIn(this.req, this.res, this.next)
return this.next.callCount.should.equal(0)
this.next.callCount.should.equal(0)
})
it('should call BetaProgramHandler.optIn', function() {
this.BetaProgramController.optIn(this.req, this.res, this.next)
return this.BetaProgramHandler.optIn.callCount.should.equal(1)
this.BetaProgramHandler.optIn.callCount.should.equal(1)
})
describe('when BetaProgramHandler.opIn produces an error', function() {
beforeEach(function() {
return this.BetaProgramHandler.optIn.callsArgWith(1, new Error('woops'))
this.BetaProgramHandler.optIn.callsArgWith(1, new Error('woops'))
})
it("should not redirect to '/beta/participate'", function() {
this.BetaProgramController.optIn(this.req, this.res, this.next)
return this.res.redirect.callCount.should.equal(0)
this.res.redirect.callCount.should.equal(0)
})
it('should produce an error', function() {
this.BetaProgramController.optIn(this.req, this.res, this.next)
this.next.callCount.should.equal(1)
return this.next.firstCall.args[0].should.be.instanceof(Error)
this.next.firstCall.args[0].should.be.instanceof(Error)
})
})
})
describe('optOut', function() {
beforeEach(function() {
return this.BetaProgramHandler.optOut.callsArgWith(1, null)
this.BetaProgramHandler.optOut.callsArgWith(1, null)
})
it("should redirect to '/beta/participate'", function() {
this.BetaProgramController.optOut(this.req, this.res, this.next)
this.res.redirect.callCount.should.equal(1)
return this.res.redirect.firstCall.args[0].should.equal(
'/beta/participate'
)
this.res.redirect.firstCall.args[0].should.equal('/beta/participate')
})
it('should not call next with an error', function() {
this.BetaProgramController.optOut(this.req, this.res, this.next)
return this.next.callCount.should.equal(0)
})
it('should not call next with an error', function() {
this.BetaProgramController.optOut(this.req, this.res, this.next)
return this.next.callCount.should.equal(0)
this.next.callCount.should.equal(0)
})
it('should call BetaProgramHandler.optOut', function() {
this.BetaProgramController.optOut(this.req, this.res, this.next)
return this.BetaProgramHandler.optOut.callCount.should.equal(1)
this.BetaProgramHandler.optOut.callCount.should.equal(1)
})
describe('when BetaProgramHandler.optOut produces an error', function() {
beforeEach(function() {
return this.BetaProgramHandler.optOut.callsArgWith(
1,
new Error('woops')
)
this.BetaProgramHandler.optOut.callsArgWith(1, new Error('woops'))
})
it("should not redirect to '/beta/participate'", function() {
this.BetaProgramController.optOut(this.req, this.res, this.next)
return this.res.redirect.callCount.should.equal(0)
this.res.redirect.callCount.should.equal(0)
})
it('should produce an error', function() {
this.BetaProgramController.optOut(this.req, this.res, this.next)
this.next.callCount.should.equal(1)
return this.next.firstCall.args[0].should.be.instanceof(Error)
this.next.firstCall.args[0].should.be.instanceof(Error)
})
})
})
describe('optInPage', function() {
beforeEach(function() {
return this.UserGetter.getUser.callsArgWith(1, null, this.user)
this.UserGetter.getUser.callsArgWith(1, null, this.user)
})
it('should render the opt-in page', function() {
this.BetaProgramController.optInPage(this.req, this.res, this.next)
this.res.render.callCount.should.equal(1)
const { args } = this.res.render.firstCall
return args[0].should.equal('beta_program/opt_in')
args[0].should.equal('beta_program/opt_in')
})
describe('when UserGetter.getUser produces an error', function() {
beforeEach(function() {
return this.UserGetter.getUser.callsArgWith(1, new Error('woops'))
this.UserGetter.getUser.callsArgWith(1, new Error('woops'))
})
it('should not render the opt-in page', function() {
this.BetaProgramController.optInPage(this.req, this.res, this.next)
return this.res.render.callCount.should.equal(0)
this.res.render.callCount.should.equal(0)
})
it('should produce an error', function() {
this.BetaProgramController.optInPage(this.req, this.res, this.next)
this.next.callCount.should.equal(1)
return this.next.firstCall.args[0].should.be.instanceof(Error)
this.next.firstCall.args[0].should.be.instanceof(Error)
})
})
})