From 291f28a655957a3b8a49f3a91a1f2682bea3c002 Mon Sep 17 00:00:00 2001
From: Tim Alby <timothee.alby@gmail.com>
Date: Fri, 7 Jan 2022 11:33:05 +0100
Subject: [PATCH] decaf cleanup: remove unnecessary use of Array.from

GitOrigin-RevId: 78c835929c9d7c38e0231f8fbb3e16a35efb7498
---
 .../app/js/Features/Messages/MessageFormatter.js  | 15 +++------------
 .../chat/test/acceptance/js/helpers/ChatApp.js    |  9 +--------
 2 files changed, 4 insertions(+), 20 deletions(-)

diff --git a/services/chat/app/js/Features/Messages/MessageFormatter.js b/services/chat/app/js/Features/Messages/MessageFormatter.js
index d868dca75c..ccad55d1a7 100644
--- a/services/chat/app/js/Features/Messages/MessageFormatter.js
+++ b/services/chat/app/js/Features/Messages/MessageFormatter.js
@@ -1,10 +1,3 @@
-// TODO: This file was created by bulk-decaffeinate.
-// Fix any style issues and re-enable lint.
-/*
- * decaffeinate suggestions:
- * DS101: Remove unnecessary use of Array.from
- * Full docs: https://github.com/decaffeinate/decaffeinate/blob/master/docs/suggestions.md
- */
 let MessageFormatter
 module.exports = MessageFormatter = {
   formatMessageForClientSide(message) {
@@ -25,15 +18,13 @@ module.exports = MessageFormatter = {
   },
 
   formatMessagesForClientSide(messages) {
-    return Array.from(messages).map(message =>
-      this.formatMessageForClientSide(message)
-    )
+    return messages.map(message => this.formatMessageForClientSide(message))
   },
 
   groupMessagesByThreads(rooms, messages) {
     let room, thread
     const roomsById = {}
-    for (room of Array.from(rooms)) {
+    for (room of rooms) {
       roomsById[room._id.toString()] = room
     }
 
@@ -54,7 +45,7 @@ module.exports = MessageFormatter = {
       }
     }
 
-    for (const message of Array.from(messages)) {
+    for (const message of messages) {
       room = roomsById[message.room_id.toString()]
       if (room) {
         thread = getThread(room)
diff --git a/services/chat/test/acceptance/js/helpers/ChatApp.js b/services/chat/test/acceptance/js/helpers/ChatApp.js
index 14f4c7454e..66176b5bf1 100644
--- a/services/chat/test/acceptance/js/helpers/ChatApp.js
+++ b/services/chat/test/acceptance/js/helpers/ChatApp.js
@@ -1,10 +1,3 @@
-// TODO: This file was created by bulk-decaffeinate.
-// Fix any style issues and re-enable lint.
-/*
- * decaffeinate suggestions:
- * DS101: Remove unnecessary use of Array.from
- * Full docs: https://github.com/decaffeinate/decaffeinate/blob/master/docs/suggestions.md
- */
 const { waitForDb } = require('../../../../app/js/mongodb')
 const app = require('../../../../app')
 
@@ -29,7 +22,7 @@ module.exports = {
           throw error
         }
         this.running = true
-        for (callback of Array.from(this.callbacks)) {
+        for (callback of this.callbacks) {
           callback()
         }
       })