From 2a72a785ec3d82c89b13e975171d5f0eee2a3e8b Mon Sep 17 00:00:00 2001 From: Jakob Ackermann Date: Mon, 8 May 2023 14:40:37 +0100 Subject: [PATCH] Merge pull request #12993 from overleaf/jpa-configurable-request-threshold [spelling] make ASpellWorkerPool.MAX_REQUESTS configurable via env var GitOrigin-RevId: babedafb16b05f53ba0fefc73250bcf623ec4f89 --- services/spelling/app/js/ASpellWorkerPool.js | 3 ++- services/spelling/config/settings.defaults.cjs | 3 +++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/services/spelling/app/js/ASpellWorkerPool.js b/services/spelling/app/js/ASpellWorkerPool.js index d2c43bd283..57ccf13ed0 100644 --- a/services/spelling/app/js/ASpellWorkerPool.js +++ b/services/spelling/app/js/ASpellWorkerPool.js @@ -8,6 +8,7 @@ * Full docs: https://github.com/decaffeinate/decaffeinate/blob/master/docs/suggestions.md */ import _ from 'underscore' +import Settings from '@overleaf/settings' import logger from '@overleaf/logger' import metrics from '@overleaf/metrics' import OError from '@overleaf/o-error' @@ -15,7 +16,7 @@ import { ASpellWorker } from './ASpellWorker.js' export class ASpellWorkerPool { static initClass() { - this.prototype.MAX_REQUESTS = 100 * 1024 + this.prototype.MAX_REQUESTS = Settings.maxRequestsPerWorker this.prototype.MAX_WORKERS = 32 this.prototype.MAX_IDLE_TIME = 1000 this.prototype.MAX_REQUEST_TIME = 60 * 1000 diff --git a/services/spelling/config/settings.defaults.cjs b/services/spelling/config/settings.defaults.cjs index 64e039c5cd..f6a1de94d5 100644 --- a/services/spelling/config/settings.defaults.cjs +++ b/services/spelling/config/settings.defaults.cjs @@ -8,6 +8,9 @@ module.exports = { }, }, + maxRequestsPerWorker: + parseInt(process.env.MAX_REQUESTS_PER_WORKER, 10) || 100 * 1024, + cacheDir: Path.resolve('cache'), healthCheckUserId: '53c64d2fd68c8d000010bb5f',