From 2aef71b0b8934c40afe38cb31035e3cbe965d3b7 Mon Sep 17 00:00:00 2001 From: Thomas Date: Mon, 8 Aug 2022 10:55:11 +0200 Subject: [PATCH] Merge pull request #9012 from overleaf/ab-dictionary-editor-query-override-fix [web] Remove usage of shouldDisplayFeature superseding split test query param override GitOrigin-RevId: 6e046e7fd26140b2bd721e2f2ec9303cc2e604b8 --- .../web/app/src/Features/Project/ProjectController.js | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/services/web/app/src/Features/Project/ProjectController.js b/services/web/app/src/Features/Project/ProjectController.js index 35e67fb1d8..bcc5618239 100644 --- a/services/web/app/src/Features/Project/ProjectController.js +++ b/services/web/app/src/Features/Project/ProjectController.js @@ -1111,6 +1111,7 @@ const ProjectController = { }) } + // should not be used in place of split tests query param overrides (?my-split-test-name=my-variant) function shouldDisplayFeature(name, variantFlag) { if (req.query && req.query[name]) { return req.query[name] === 'true' @@ -1135,8 +1136,7 @@ const ProjectController = { } const showNewSourceEditorOption = - (newSourceEditorAssignment && - newSourceEditorAssignment.variant === 'codemirror') || + newSourceEditorAssignment?.variant === 'codemirror' || user.betaProgram || shouldDisplayFeature('new_source_editor', false) // also allow override via ?new_source_editor=true @@ -1146,10 +1146,7 @@ const ProjectController = { const dictionaryEditorEnabled = !Features.hasFeature('saas') || - shouldDisplayFeature( - 'dictionary-editor', - dictionaryEditorAssignment.variant === 'enabled' - ) + dictionaryEditorAssignment?.variant === 'enabled' // Persistent upgrade prompts // in header & in share project modal