From 2ca7c344a3a8874a7f0a3e21fb255ee546df333d Mon Sep 17 00:00:00 2001 From: Henry Oswald Date: Thu, 10 Apr 2014 12:39:13 +0100 Subject: [PATCH] reformtted reg handler tests --- .../User/UserRegistrationHandler.coffee | 6 + .../User/UserRegistrationHandlerTests.coffee | 115 +++++++++--------- 2 files changed, 65 insertions(+), 56 deletions(-) diff --git a/services/web/app/coffee/Features/User/UserRegistrationHandler.coffee b/services/web/app/coffee/Features/User/UserRegistrationHandler.coffee index c6672f6adf..c5983c6665 100644 --- a/services/web/app/coffee/Features/User/UserRegistrationHandler.coffee +++ b/services/web/app/coffee/Features/User/UserRegistrationHandler.coffee @@ -28,3 +28,9 @@ module.exports = callback('not valid email', null) else callback(null, {first_name:first_name, last_name:last_name, email:email, password:password}) + + + + registerNewUser: (userDetails, callback)-> + + callback() \ No newline at end of file diff --git a/services/web/test/UnitTests/coffee/User/UserRegistrationHandlerTests.coffee b/services/web/test/UnitTests/coffee/User/UserRegistrationHandlerTests.coffee index 062f3cd896..74dc9ba960 100644 --- a/services/web/test/UnitTests/coffee/User/UserRegistrationHandlerTests.coffee +++ b/services/web/test/UnitTests/coffee/User/UserRegistrationHandlerTests.coffee @@ -4,64 +4,67 @@ assert = require('assert') path = require('path') modulePath = path.join __dirname, '../../../../app/js/Features/User/UserRegistrationHandler' - - -describe 'validate Register Request', -> - passingRequest = undefined - controller = undefined +describe "UserRegistrationHandler", -> + beforeEach -> - controller = SandboxedModule.require modulePath, requires:{} - passingRequest = {body:{email:"something@email.com", password:"123"}} + @handler = SandboxedModule.require modulePath, requires:{} + @passingRequest = {body:{email:"something@email.com", password:"123"}} - it 'allow working account through', -> - controller.validateRegisterRequest passingRequest, (err, data)-> - should.not.exist(err) - data.first_name.should.equal "something" - data.last_name.should.equal "" - data.email.should.equal passingRequest.body.email - data.password.should.equal passingRequest.body.password - - it 'not allow not valid email through ', (done)-> - passingRequest.body.email = "notemail" - controller.validateRegisterRequest passingRequest, (err, data)-> - should.exist(err) - err.should.equal "not valid email" - done() - - it 'not allow no email through ', -> - passingRequest.body.email = "" - controller.validateRegisterRequest passingRequest, (err, data)-> - should.exist(err) - err.should.equal "please fill in all the fields" - - it 'not allow no password through ', (done)-> - passingRequest.body.password= "" - controller.validateRegisterRequest passingRequest, (err, data)-> - should.exist(err) - err.should.equal "please fill in all the fields" - done() - it 'trim white space from email', (done)-> - passingRequest.body.email = " some@email.com " - controller.validateRegisterRequest passingRequest, (err, data)-> - should.not.exist(err) - data.email.should.equal "some@email.com" - done() + describe 'validate Register Request', -> + + + it 'allow working account through', -> + @handler.validateRegisterRequest @passingRequest, (err, data)=> + should.not.exist(err) + data.first_name.should.equal "something" + data.last_name.should.equal "" + data.email.should.equal @passingRequest.body.email + data.password.should.equal @passingRequest.body.password + + it 'not allow not valid email through ', (done)-> + @passingRequest.body.email = "notemail" + @handler.validateRegisterRequest @passingRequest, (err, data)-> + should.exist(err) + err.should.equal "not valid email" + done() + + it 'not allow no email through ', -> + @passingRequest.body.email = "" + @handler.validateRegisterRequest @passingRequest, (err, data)-> + should.exist(err) + err.should.equal "please fill in all the fields" + + it 'not allow no password through ', (done)-> + @passingRequest.body.password= "" + @handler.validateRegisterRequest @passingRequest, (err, data)-> + should.exist(err) + err.should.equal "please fill in all the fields" + done() + + it 'trim white space from email', (done)-> + @passingRequest.body.email = " some@email.com " + @handler.validateRegisterRequest @passingRequest, (err, data)-> + should.not.exist(err) + data.email.should.equal "some@email.com" + done() + + it 'lower case email', (done)-> + @passingRequest.body.email = "soMe@eMail.cOm" + @handler.validateRegisterRequest @passingRequest, (err, data)-> + should.not.exist(err) + data.email.should.equal "some@email.com" + done() + + it 'should allow a short registeration request through', (done) -> + @handler.validateRegisterRequest body: { + email: "user_name@example.com" + password: @passingRequest.body.password + }, (err, data) => + should.not.exist(err) + data.email.should.equal "user_name@example.com" + data.password.should.equal @passingRequest.body.password + data.first_name.should.equal "user_name" + done() - it 'lower case email', (done)-> - passingRequest.body.email = "soMe@eMail.cOm" - controller.validateRegisterRequest passingRequest, (err, data)-> - should.not.exist(err) - data.email.should.equal "some@email.com" - done() - it 'should allow a short registeration request through', (done) -> - controller.validateRegisterRequest body: { - email: "user_name@example.com" - password: passingRequest.body.password - }, (err, data) -> - should.not.exist(err) - data.email.should.equal "user_name@example.com" - data.password.should.equal passingRequest.body.password - data.first_name.should.equal "user_name" - done()