Merge pull request #2032 from overleaf/as-upgrade-webpack

Upgrade webpack to v4

GitOrigin-RevId: a92c487fee79c29c5314273bf05439c9dbb0ce4d

services/web/webpack.config.js

@@ -1,92 +1,83 @@
 const fs = require('fs')
 const path = require('path')
-const webpack = require('webpack')
 
 const MODULES_PATH = path.join(__dirname, '/modules')
-const webpackENV = process.env.WEBPACK_ENV || 'development'
 
 // Generate a hash of entry points, including modules
 const entryPoints = {}
 if (fs.existsSync(MODULES_PATH)) {
-	fs.readdirSync(MODULES_PATH).reduce((acc, module) => {
-		const entryPath = path.join(MODULES_PATH, module, '/public/es/index.js')
-		if (fs.existsSync(entryPath)) {
-			acc[module] = entryPath
-		}
-		return acc
-	}, entryPoints)
+  fs.readdirSync(MODULES_PATH).reduce((acc, module) => {
+    const entryPath = path.join(MODULES_PATH, module, '/public/es/index.js')
+    if (fs.existsSync(entryPath)) {
+      acc[module] = entryPath
+    }
+    return acc
+  }, entryPoints)
 }
 
 // If no entry points are found, silently exit
 if (!Object.keys(entryPoints).length) {
-	console.warn('No entry points found, exiting')
-	process.exit(0)
+  console.warn('No entry points found, exiting')
+  process.exit(0)
 }
 
 module.exports = {
-	// Defines the "entry point(s)" for the application - i.e. the file which
-	// bootstraps the application
-	entry: entryPoints,
+  // Defines the "entry point(s)" for the application - i.e. the file which
+  // bootstraps the application
+  entry: entryPoints,
 
-	// Define where and how the bundle will be output to disk
-	// Note: webpack-dev-server does not write the bundle to disk, instead it is
-	// kept in memory for speed
-	output: {
-		path: path.join(__dirname, '/public/js/es'),
+  // Define where and how the bundle will be output to disk
+  // Note: webpack-dev-server does not write the bundle to disk, instead it is
+  // kept in memory for speed
+  output: {
+    path: path.join(__dirname, '/public/js/es'),
 
-		filename: '[name].js',
+    filename: '[name].js',
 
-		// Output as UMD bundle (allows main JS to import with CJS, AMD or global
-		// style code bundles
-		libraryTarget: 'umd',
-		// Name the exported variable from output bundle
-		library: ['Frontend', '[name]']
-	},
+    // Output as UMD bundle (allows main JS to import with CJS, AMD or global
+    // style code bundles
+    libraryTarget: 'umd',
+    // Name the exported variable from output bundle
+    library: ['Frontend', '[name]']
+  },
 
-	// Define how file types are handled by webpack
-	module: {
-		rules: [{
-			// Pass application JS files through babel-loader, compiling to ES5
-			test: /\.js$/,
-			// Only compile application files (dependencies are in ES5 already)
-			exclude: /node_modules/,
-			use: [{
-				loader: 'babel-loader',
-				options: {
-					// Configure babel-loader to cache compiled output so that subsequent
-					// compile runs are much faster
-					cacheDirectory: true
-				}
-			}]
-		},
-		{
-			// These options are necesary for handlebars to have access to helper
-			// methods
-			test: /\.handlebars$/,
-			loader: "handlebars-loader",
-			options: {
-				compat: true,
-				knownHelpersOnly: false,
-				runtimePath: 'handlebars/runtime',
-			}
-		}]
-	},
-	resolve: {
-		alias: {
-			// makes handlerbars globally accessible to backbone
-			handlebars: 'handlebars/dist/handlebars.min.js',
-			jquery: path.join(__dirname, 'node_modules/jquery/dist/jquery'),
-		}
-	},
-	plugins: [
-		new webpack.DefinePlugin({
-			// Swaps out checks for NODE_ENV with the env. This is used by various
-			// libs to enable dev-only features. These checks then become something
-			// like `if ('production' == 'production')`. Minification will then strip
-			// the dev-only code from the bundle
-			'process.env': {
-				NODE_ENV: JSON.stringify(webpackENV)
-			},
-		})
-	]
+  // Define how file types are handled by webpack
+  module: {
+    rules: [
+      {
+        // Pass application JS files through babel-loader, compiling to ES5
+        test: /\.js$/,
+        // Only compile application files (dependencies are in ES5 already)
+        exclude: /node_modules/,
+        use: [
+          {
+            loader: 'babel-loader',
+            options: {
+              // Configure babel-loader to cache compiled output so that
+              // subsequent compile runs are much faster
+              cacheDirectory: true
+            }
+          }
+        ]
+      },
+      {
+        // These options are neccesary for handlebars to have access to helper
+        // methods
+        test: /\.handlebars$/,
+        loader: 'handlebars-loader',
+        options: {
+          compat: true,
+          knownHelpersOnly: false,
+          runtimePath: 'handlebars/runtime'
+        }
+      }
+    ]
+  },
+  resolve: {
+    alias: {
+      // makes handlebars globally accessible to backbone
+      handlebars: 'handlebars/dist/handlebars.min.js',
+      jquery: path.join(__dirname, 'node_modules/jquery/dist/jquery')
+    }
+  }
 }