From 2e5d57cd994b168cbf4c291a30ed776790dbd8df Mon Sep 17 00:00:00 2001 From: Brian Gough Date: Wed, 7 Jun 2017 11:47:28 +0100 Subject: [PATCH] don't increase rate limit when tasks are failing --- services/document-updater/app/coffee/RateLimitManager.coffee | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/services/document-updater/app/coffee/RateLimitManager.coffee b/services/document-updater/app/coffee/RateLimitManager.coffee index 118323f6f1..7128b5d988 100644 --- a/services/document-updater/app/coffee/RateLimitManager.coffee +++ b/services/document-updater/app/coffee/RateLimitManager.coffee @@ -34,5 +34,6 @@ module.exports = class RateLimiter @_adjustLimitDown() else logger.log {active: @ActiveWorkerCount, currentLimit: Math.ceil(@CurrentWorkerLimit)}, "hit rate limit" - @_trackAndRun task, callback # only return after task completes - @_adjustLimitUp() + @_trackAndRun task, (err) => + @_adjustLimitUp() if !err? # don't increment rate limit if there was an error + callback(err) # only return after task completes