From 2ec300ee9108c55f81fcccef8b9a33780e27dae5 Mon Sep 17 00:00:00 2001 From: M Fahru Date: Fri, 30 Aug 2024 06:06:30 -0700 Subject: [PATCH] Merge pull request #20024 from overleaf/mf-plans-page-click [web] Implement `plans-page-click` event on new plans page GitOrigin-RevId: 1dbfc5faa433985c1ad81ba645cdb8f6f3a0b864 --- services/web/frontend/js/features/event-tracking/index.js | 7 +++++-- .../js/pages/user/subscription/plans-v2/plans-v2-main.js | 1 - 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/services/web/frontend/js/features/event-tracking/index.js b/services/web/frontend/js/features/event-tracking/index.js index 339555f593..beae334153 100644 --- a/services/web/frontend/js/features/event-tracking/index.js +++ b/services/web/frontend/js/features/event-tracking/index.js @@ -10,10 +10,13 @@ function setupEventTracking(el) { const trigger = el.getAttribute('event-tracking-trigger') const sendOnce = el.getAttribute('event-tracking-send-once') const element = el.getAttribute('event-tracking-element') - const segmentation = JSON.parse(el.getAttribute('event-segmentation') || '{}') - segmentation.page = window.location.pathname function submit() { + const segmentation = JSON.parse( + el.getAttribute('event-segmentation') || '{}' + ) + segmentation.page = window.location.pathname + if (element === 'checkbox') { segmentation.checkbox = el.checked ? 'checked' : 'unchecked' } else if (element === 'select') { diff --git a/services/web/frontend/js/pages/user/subscription/plans-v2/plans-v2-main.js b/services/web/frontend/js/pages/user/subscription/plans-v2/plans-v2-main.js index 2e23480110..099bb279b1 100644 --- a/services/web/frontend/js/pages/user/subscription/plans-v2/plans-v2-main.js +++ b/services/web/frontend/js/pages/user/subscription/plans-v2/plans-v2-main.js @@ -56,7 +56,6 @@ function setUpSubscriptionTracking(linkEl) { 'billing-period': period, } - eventTracking.sendMB('plans-page-start-trial') // deprecated by plans-page-click eventTracking.sendMB(eventTrackingKey, eventTrackingSegmentation) }) }