From 31e4e16c0b3d07adc7a79c33c9b5c26945c35bf4 Mon Sep 17 00:00:00 2001 From: Thomas Date: Tue, 19 Sep 2023 15:09:33 +0200 Subject: [PATCH] Merge pull request #14882 from overleaf/tm-compile-time-warning-would-display Fix unreachable 'compile time warning would display' event GitOrigin-RevId: 3734ef69062d11cdde851447c657a58259d00acf --- .../components/compile-time-warning.tsx | 30 ++++++++++++++++--- .../components/compile-timeout-messages.tsx | 7 +---- 2 files changed, 27 insertions(+), 10 deletions(-) diff --git a/services/web/frontend/js/features/pdf-preview/components/compile-time-warning.tsx b/services/web/frontend/js/features/pdf-preview/components/compile-time-warning.tsx index 4caa170fc4..4b059a3119 100644 --- a/services/web/frontend/js/features/pdf-preview/components/compile-time-warning.tsx +++ b/services/web/frontend/js/features/pdf-preview/components/compile-time-warning.tsx @@ -6,7 +6,7 @@ import StartFreeTrialButton from '../../../shared/components/start-free-trial-bu import { useDetachCompileContext } from '../../../shared/context/detach-compile-context' import usePersistedState from '../../../shared/hooks/use-persisted-state' -const ONE_DAY = 24 * 60 * 60 * 24 * 1000 +const TWENTY_FOUR_DAYS = 24 * 60 * 60 * 24 * 1000 function CompileTimeWarning() { const { t } = useTranslation() @@ -17,14 +17,36 @@ function CompileTimeWarning() { true ) - const { showCompileTimeWarning, setShowCompileTimeWarning } = - useDetachCompileContext() + const { + showCompileTimeWarning, + setShowCompileTimeWarning, + deliveryLatencies, + isProjectOwner, + } = useDetachCompileContext() + + useEffect(() => { + if (deliveryLatencies && deliveryLatencies.compileTimeServerE2E) { + window.sl_console.log( + `[compileTimeout] compiledTimeServerE2E ${ + deliveryLatencies.compileTimeServerE2E / 1000 + }s` + ) + // compile-timeout-20s test + if (deliveryLatencies.compileTimeServerE2E > 10000) { + eventTracking.sendMB('compile-time-warning-would-display', { + time: 10, + newCompileTimeout: 'control', + isProjectOwner, + }) + } + } + }, [deliveryLatencies, isProjectOwner]) useEffect(() => { if (showCompileTimeWarning) { if ( displayStatus && - Date.now() - displayStatus.lastDisplayTime < ONE_DAY + Date.now() - displayStatus.lastDisplayTime < TWENTY_FOUR_DAYS ) { return } diff --git a/services/web/frontend/js/features/pdf-preview/components/compile-timeout-messages.tsx b/services/web/frontend/js/features/pdf-preview/components/compile-timeout-messages.tsx index fef3ea4ad1..4b304badd1 100644 --- a/services/web/frontend/js/features/pdf-preview/components/compile-timeout-messages.tsx +++ b/services/web/frontend/js/features/pdf-preview/components/compile-timeout-messages.tsx @@ -26,7 +26,7 @@ function CompileTimeoutMessages() { const segmentation = useMemo(() => { return { - newCompileTimeout: showNewCompileTimeoutUI || 'control', + newCompileTimeout: showNewCompileTimeoutUI, isProjectOwner, } }, [showNewCompileTimeoutUI, isProjectOwner]) @@ -59,11 +59,6 @@ function CompileTimeoutMessages() { ...segmentation, }) } - } else { - eventTracking.sendMB('compile-time-warning-would-display', { - time: 10, - ...segmentation, - }) } } },