From 320466a4f7259f72be1b60a3df6d14189d418e88 Mon Sep 17 00:00:00 2001 From: Alasdair Smith Date: Wed, 6 Sep 2017 13:47:45 +0100 Subject: [PATCH] Catch invalid email address and show specific error message --- services/web/app/views/project/editor/share.pug | 2 ++ .../share/controllers/ShareProjectModalController.coffee | 7 +++++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/services/web/app/views/project/editor/share.pug b/services/web/app/views/project/editor/share.pug index 11e1145863..ae59185b9d 100644 --- a/services/web/app/views/project/editor/share.pug +++ b/services/web/app/views/project/editor/share.pug @@ -147,6 +147,8 @@ script(type='text/ng-template', id='shareProjectModalTemplate') | #{translate("cannot_invite_non_user")} span(ng-switch-when="cannot_invite_self") | #{translate("cannot_invite_self")} + span(ng-switch-when="invalid_email") + | #{translate("invalid_email")} span(ng-switch-default) | #{translate("generic_something_went_wrong")} button.btn.btn-default( diff --git a/services/web/public/coffee/ide/share/controllers/ShareProjectModalController.coffee b/services/web/public/coffee/ide/share/controllers/ShareProjectModalController.coffee index 5ede187dce..2cf6aaa8ec 100644 --- a/services/web/public/coffee/ide/share/controllers/ShareProjectModalController.coffee +++ b/services/web/public/coffee/ide/share/controllers/ShareProjectModalController.coffee @@ -127,10 +127,13 @@ define [ # with new collaborator information. addNextMember() , 0 - .catch () -> + .catch (err) -> $scope.state.inflight = false $scope.state.error = true - $scope.state.errorReason = null + if (err.status? and err.status == 400) + $scope.state.errorReason = 'invalid_email' + else + $scope.state.errorReason = null $timeout addMembers, 50 # Give email list a chance to update