From 3515d7b8eb1db0dd809af113e58a630e5cf95a0b Mon Sep 17 00:00:00 2001 From: Andrew Rumble Date: Wed, 16 Apr 2025 14:16:14 +0100 Subject: [PATCH] Log more information for failing tests GitOrigin-RevId: 22ae2151b476b4f810ab9223b42f9cb6fe9d7442 --- .../acceptance/js/api/backupVerifier.test.mjs | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/services/history-v1/test/acceptance/js/api/backupVerifier.test.mjs b/services/history-v1/test/acceptance/js/api/backupVerifier.test.mjs index cf9c58d0ea..1fe09f4b1c 100644 --- a/services/history-v1/test/acceptance/js/api/backupVerifier.test.mjs +++ b/services/history-v1/test/acceptance/js/api/backupVerifier.test.mjs @@ -71,7 +71,7 @@ async function verifyProjectScript(historyId, expectFail = true) { * @param {string} hash * @return {Promise<{stdout: string, status:number }>} */ -async function verifyBlobScript(historyId, hash) { +async function verifyBlobScript(historyId, hash, expectFail = true) { try { const result = await promisify(execFile)( process.argv0, @@ -92,6 +92,9 @@ async function verifyBlobScript(historyId, hash) { return { status: 0, stdout: result.stdout } } catch (err) { if (err && typeof err === 'object' && 'stdout' in err && 'code' in err) { + if (!expectFail) { + console.log(err) + } return { stdout: typeof err.stdout === 'string' ? err.stdout : '', status: typeof err.code === 'number' ? err.code : -1, @@ -309,12 +312,20 @@ describe('backupVerifier', function () { expect(result.stdout).to.include('hash mismatch for backed up blob') }) it('should successfully verify from postgres', async function () { - const result = await verifyBlobScript(historyIdPostgres, blobHashPG) + const result = await verifyBlobScript( + historyIdPostgres, + blobHashPG, + false + ) expect(result.status).to.equal(0) expect(result.stdout.split('\n')).to.include('OK') }) it('should successfully verify from mongo', async function () { - const result = await verifyBlobScript(historyIdMongo, blobHashMongo) + const result = await verifyBlobScript( + historyIdMongo, + blobHashMongo, + false + ) expect(result.status).to.equal(0) expect(result.stdout.split('\n')).to.include('OK') })