agw/overleaf-cep
1
0
Fork 0
mirror of https://github.com/yu-i-i/overleaf-cep.git synced 2026-11-13 21:53:43 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #35855 from overleaf/ds-unable-to-sync-modal-improved

Browse Source 
[WEB] Adding improved version of the unable to sync modal

GitOrigin-RevId: 1cfe2b3a2e8417028339efddb18385a5224e50c3
This commit is contained in:
Davinder Singh
2026-09-17 11:43:20 +00:00
committed by Copybot
parent 469f5629d2
commit 36d0a5c227
11 changed files with 241 additions and 72 deletions
Download Patch File Download Diff File Expand all files Collapse all files
services/web/test/frontend/features/ide-react/context/editor-manager-context-out-of-sync.spec.tsx
+9 -28
View File
@@ -168,9 +168,8 @@ describe('EditorManagerProvider docError sync modals', function () {
cy.findByRole('dialog').within(() => {
cy.findByText('Your offline edits couldn’t be synced').should('exist')
cy.findByRole('button', { name: 'Download local version' }).should(
'exist'
)
cy.findByRole('button', { name: 'Save as new file' }).should('exist')
cy.findByRole('button', { name: 'Discard changes' }).should('exist')
})
cy.then(() => {
@@ -204,30 +203,12 @@ describe('EditorManagerProvider docError sync modals', function () {
})
})
it('passes editorContent and docName through to the download button', function () {
it('passes editorContent and docName through to the modal', function () {
cy.then(() => {
setSplitTest(true)
plantBackup(CURRENT_DOC_ID)
})
const captured: { blob: Blob | null; filename: string | null } = {
blob: null,
filename: null,
}
cy.window().then(win => {
cy.stub(win.URL, 'createObjectURL').callsFake((blob: Blob) => {
captured.blob = blob
return 'blob:mock'
})
cy.stub(win.URL, 'revokeObjectURL')
cy.stub(win.HTMLAnchorElement.prototype, 'click').callsFake(function (
this: HTMLAnchorElement
) {
captured.filename = this.download
})
})
mount()
cy.then(() => {
@@ -239,12 +220,11 @@ describe('EditorManagerProvider docError sync modals', function () {
)
})
cy.findByRole('button', { name: 'Download local version' }).click()
cy.then(() => {
expect(captured.filename).to.equal(currentDoc.docName)
return captured.blob!.text()
}).should('equal', 'the exact offline content')
cy.findByRole('dialog').within(() => {
cy.findByText('Your offline edits couldn’t be synced').should('exist')
cy.findByRole('button', { name: 'Save as new file' }).should('exist')
cy.findByRole('button', { name: 'Discard changes' }).should('exist')
})
})
it('falls back to OutOfSyncModal when no backup exists', function () {
@@ -289,6 +269,7 @@ describe('EditorManagerProvider docError sync modals', function () {
capturedEmitter!.emit('ide:unableToSyncOfflineChanges', {
docId: CURRENT_DOC_ID,
editorContent: 'recovered content',
baseContent: 'original content',
docName: 'recovered.tex',
})
})