From 36eb453aed4b3cc7fd407429116f94926cdca2ad Mon Sep 17 00:00:00 2001
From: Shane Kilkelly <shane@kilkelly.me>
Date: Fri, 20 Jan 2017 13:52:31 +0000
Subject: [PATCH] Clarify logic of asyncform onsuccess and onerror handlers

---
 services/web/public/coffee/directives/asyncForm.coffee | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/services/web/public/coffee/directives/asyncForm.coffee b/services/web/public/coffee/directives/asyncForm.coffee
index b3e13e8d61..d9ca11231b 100644
--- a/services/web/public/coffee/directives/asyncForm.coffee
+++ b/services/web/public/coffee/directives/asyncForm.coffee
@@ -33,7 +33,8 @@ define [
 							response.success = true
 							response.error = false
 
-							if onSuccessHandler = scope[attrs.onSuccess]
+							onSuccessHandler = scope[attrs.onSuccess]
+							if onSuccessHandler
 								onSuccessHandler(data, status, headers, config)
 								return
 
@@ -55,7 +56,8 @@ define [
 							response.success = false
 							response.error = true
 
-							if onErrorHandler = scope[attrs.onError]
+							onErrorHandler = scope[attrs.onError]
+							if onErrorHandler
 								onErrorHandler(data, status, headers, config)
 								return