From 3b57d62de26f96d0def22bb0a9cb64ceba31bb7c Mon Sep 17 00:00:00 2001
From: James Allen <james@sharelatex.com>
Date: Fri, 27 Jun 2014 21:19:14 +0100
Subject: [PATCH] Refactor project list select all to use linked directives

---
 services/web/app/views/project/list.jade      | 13 ++-
 .../coffee/app/main/project-list.coffee       | 95 ++++++++++++++-----
 2 files changed, 78 insertions(+), 30 deletions(-)

diff --git a/services/web/app/views/project/list.jade b/services/web/app/views/project/list.jade
index 42822e6e67..f5d87f3038 100644
--- a/services/web/app/views/project/list.jade
+++ b/services/web/app/views/project/list.jade
@@ -259,14 +259,13 @@ block content
 							.col-md-12
 								.card.card-thin
 									- if (projects.length > 0)
-										ul.list-unstyled.project-list(ng-cloak)
+										ul.list-unstyled.project-list(select-all-list, ng-cloak)
 											li.container-fluid
 												.row
 													.col-md-6
 														input.select-all(
-															type="checkbox",
-															ng-model="allSelected",
-															ng-change="onSelectAllChange()"
+															select-all,
+															type="checkbox"
 														)
 														span.title TITLE
 													.col-md-2
@@ -279,7 +278,11 @@ block content
 											)
 												.row
 													.col-md-6
-														input.select-item(type="checkbox", ng-model="project.selected", ng-change="onSelectedChange()")
+														input.select-item(
+															select-individual,
+															type="checkbox",
+															ng-model="project.selected"
+														)
 														span.title
 															a.projectName(href="/project/{{project.id}}") {{project.name}}
 														span
diff --git a/services/web/public/coffee/app/main/project-list.coffee b/services/web/public/coffee/app/main/project-list.coffee
index 9879933ad6..dc4a76c75c 100644
--- a/services/web/public/coffee/app/main/project-list.coffee
+++ b/services/web/public/coffee/app/main/project-list.coffee
@@ -1,6 +1,71 @@
 define [
 	"base"
 ], (App) ->
+	App.directive "selectAllList", () ->
+		return {
+			controller: ["$scope", ($scope) ->
+				# Selecting or deselecting all should apply to all projects
+				selectAll = () ->
+					$scope.$broadcast "select-all:select"
+
+				deselectAll = () ->
+					$scope.$broadcast "select-all:deselect"
+
+				clearSelectAllState = () ->
+					$scope.$broadcast "select-all:clear"
+
+				return {
+					clearSelectAllState: clearSelectAllState
+					selectAll: selectAll
+					deselectAll: deselectAll
+				}
+			]
+			link: (scope, element, attrs) ->
+
+
+		}
+
+	App.directive "selectAll", () ->
+		return {
+			require: "^selectAllList"
+			link: (scope, element, attrs, selectAllListController) ->
+				scope.$on "select-all:clear", () ->
+					element.prop("checked", false)
+
+				element.change () ->
+					if element.is(":checked")
+						selectAllListController.selectAll()
+					else
+						selectAllListController.deselectAll()
+					return true
+		}
+
+	App.directive "selectIndividual", () ->
+		return {
+			require: "^selectAllList"
+			scope: {
+				ngModel: "="
+			}
+			link: (scope, element, attrs, selectAllListController) ->
+				ignoreChanges = false
+
+				scope.$watch "ngModel", (value) ->
+					if value? and !ignoreChanges
+						selectAllListController.clearSelectAllState()
+
+				scope.$on "select-all:select", () ->
+					ignoreChanges = true
+					scope.$apply () ->
+						scope.ngModel = true
+					ignoreChanges = false
+
+				scope.$on "select-all:deselect", () ->
+					ignoreChanges = true
+					scope.$apply () ->
+						scope.ngModel = false
+					ignoreChanges = false
+		}
+
 	App.factory "queuedHttp", ["$http", "$q", ($http, $q) ->
 		pendingRequests = []
 		inflight = false
@@ -70,18 +135,6 @@ define [
 					project.tags ||= []
 					project.tags.push tag
 
-		# Any individual changes to the selection buttons invalidates
-		# our 'select all'
-		$scope.$on "selected:on-change", (e) ->
-			$scope.allSelected = false
-			$scope.$broadcast "selection:change"
-
-		# Selecting or deselecting all should apply to all projects
-		$scope.onSelectAllChange = () ->
-			for project in $scope.visibleProjects
-				project.selected = $scope.allSelected
-			$scope.$broadcast "selection:change"
-
 		$scope.$watch "searchText", (value) ->
 			$scope.updateVisibleProjects()
 
@@ -93,12 +146,6 @@ define [
 			$scope.filter = filter
 			$scope.updateVisibleProjects()
 
-		$scope.clearProjectSelections = () ->
-			for project in $scope.projects
-				project.selected = false
-			$scope.allSelected = false
-			$scope.$broadcast "selection:change"
-
 		$scope.updateSelectedProjects = () ->
 			$scope.selectedProjects = $scope.projects.filter (project) -> project.selected
 
@@ -111,9 +158,6 @@ define [
 		$scope.getFirstSelectedProject = () ->
 			$scope.selectedProjects[0]
 
-		$scope.$on "selection:change", () ->
-			$scope.updateSelectedProjects()
-
 		$scope.updateVisibleProjects = () ->
 			$scope.visibleProjects = []
 			selectedTag = $scope.getSelectedTag()
@@ -446,9 +490,6 @@ define [
 
 
 	App.controller "ProjectListItemController", ($scope) ->
-		$scope.onSelectedChange = () ->
-			$scope.$emit "selected:on-change"
-
 		$scope.ownerName = () ->
 			if $scope.project.accessLevel == "owner"
 				return "You"
@@ -457,6 +498,10 @@ define [
 			else
 				return "?"
 
+		$scope.$watch "project.selected", (value) ->
+			if value?
+				$scope.updateSelectedProjects()
+
 	App.controller "TagListController", ($scope) ->
 		$scope.filterProjects = (filter = "all") ->
 			$scope._clearTags()
@@ -498,7 +543,7 @@ define [
 				$scope.addSelectedProjectsToTag($scope.tag)
 				$scope.areSelectedProjectsInTag = true
 
-		$scope.$on "selection:change", (e, newValue, oldValue) ->
+		$scope.$watch "selectedProjects", () ->
 			$scope.recalculateProjectsInTag()
 		$scope.recalculateProjectsInTag()