agw/overleaf-cep
1
0
Fork 0
mirror of https://github.com/yu-i-i/overleaf-cep.git synced 2026-11-14 22:23:42 +01:00
Code Issues Packages Projects Releases Wiki Activity

Update loading spinner status (#28177)

Browse Source 
* Update test for the loading spinner component

* Create a story for the loading spinner component

* Move role and use CSS for spacing instead

* Add a classname prop

* Reuse LoadingSpinner

* Use OLSpinner instead of Spinner

* Use data-testid since status role was moved

* Wait for journals to load

* Use `isLoading` prop instead and fix the button's height

* Use `isLoading` prop instead

* Use LoadingSpinner instead and remove spacing

* Update test for the loading spinner component

* Use `isLoading` prop instead

* Add aria-describedby to layout button for processing state

* Replace `spinner` to `ol-spinner`

* Scope status

* Remove redundant `div.loading`

---------

Co-authored-by: Antoine Clausse <antoine.clausse@overleaf.com>
GitOrigin-RevId: 8f43b991f8f458b2abd5a4661913ac9b972d892a
This commit is contained in:
Rebeka Dekany
2025-09-26 08:05:46 +00:00
committed by Copybot
co-authored by Antoine Clausse
parent aebff54a6b
commit 3b5ea89a1c
27 changed files with 123 additions and 212 deletions
Download Patch File Download Diff File Expand all files Collapse all files
services/web/test/frontend/components/shared/select.spec.tsx
+3 -3
View File
@@ -63,7 +63,7 @@ describe('<Select />', function () {
describe('initial rendering', function () {
it('renders default text', function () {
render({ defaultText: 'Choose an item' })
cy.findByTestId('spinner').should('not.exist')
cy.findByTestId('ol-spinner').should('not.exist')
cy.findByRole('combobox').should('have.value', 'Choose an item')
})
@@ -102,7 +102,7 @@ describe('<Select />', function () {
label: 'test label',
loading: true,
})
cy.findByTestId('spinner')
cy.findByTestId('ol-spinner')
})
it('does not render a spinner while loading if there is no label', function () {
@@ -110,7 +110,7 @@ describe('<Select />', function () {
defaultText: 'Choose an item',
loading: true,
})
cy.findByTestId('spinner').should('not.exist')
cy.findByTestId('ol-spinner').should('not.exist')
})
})