From 3c2351c22f77edde3ec50640937f23dc3b4b46a2 Mon Sep 17 00:00:00 2001 From: Miguel Serrano Date: Wed, 10 Mar 2021 13:18:25 +0100 Subject: [PATCH] Merge pull request #3740 from overleaf/ae-safari-remove-event-listener Add required arguments for removeEventListener in Safari GitOrigin-RevId: ad1cc79b12e56dc1019920964a93acbe1bec10ff --- .../frontend/js/ide/SafariScrollPatcher.js | 20 +++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/services/web/frontend/js/ide/SafariScrollPatcher.js b/services/web/frontend/js/ide/SafariScrollPatcher.js index f2a00737ef..6768ac236a 100644 --- a/services/web/frontend/js/ide/SafariScrollPatcher.js +++ b/services/web/frontend/js/ide/SafariScrollPatcher.js @@ -50,13 +50,25 @@ export default SafariScrollPatcher = class SafariScrollPatcher { // If elements aren't null, remove existing listeners. if (this.pdfDiv != null) { - this.pdfDiv.removeEventListener(this.handlePdfDivMouseLeave) - this.pdfDiv.removeEventListener(this.handlePdfDivMouseEnter) + this.pdfDiv.removeEventListener( + 'mouseleave', + this.handlePdfDivMouseLeave + ) + this.pdfDiv.removeEventListener( + 'mouseenter', + this.handlePdfDivMouseEnter + ) } if (this.aceDiv != null) { - this.aceDiv.removeEventListener(this.handleAceDivMouseLeave) - this.aceDiv.removeEventListener(this.handleAceDivMouseEnter) + this.aceDiv.removeEventListener( + 'mouseleave', + this.handleAceDivMouseLeave + ) + this.aceDiv.removeEventListener( + 'mouseenter', + this.handleAceDivMouseEnter + ) } // Grab elements.