From 3cb7ef05d9cda9502898620f23723df686011947 Mon Sep 17 00:00:00 2001 From: Rebeka Dekany <50901361+rebekadekany@users.noreply.github.com> Date: Mon, 12 May 2025 18:09:17 +0200 Subject: [PATCH] Fix undefined alt text for images (#25447) GitOrigin-RevId: 59efe870275f3dcbabecf1c3d115e7a7a85be594 --- services/web/app/views/_mixins/quote.pug | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/services/web/app/views/_mixins/quote.pug b/services/web/app/views/_mixins/quote.pug index b8065dbdab..573e0b6b0c 100644 --- a/services/web/app/views/_mixins/quote.pug +++ b/services/web/app/views/_mixins/quote.pug @@ -1,9 +1,10 @@ -mixin quoteLargeTextCentered(quote, person, position, affiliation, link, pictureUrl, pictureAltAttr) +mixin quoteLargeTextCentered(quote, person, position, affiliation, link, pictureUrl) blockquote.quote-large-text-centered .quote !{quote} if pictureUrl .quote-img - img(src=pictureUrl alt=pictureAltAttr) + -var pictureAlt=`Photo of ${person}` + img(src=pictureUrl alt=pictureAlt) footer div.quote-person strong #{person} @@ -33,7 +34,7 @@ mixin collinsQuote1 -var quotePersonPosition = 'Associate Professor and Lab Director, Ontario Tech University' -var quotePersonImg = buildImgPath("advocates/collins.jpg") .card-body - +quoteLargeTextCentered(quote, quotePerson, quotePersonPosition, null, null, quotePersonImg, quotePerson) + +quoteLargeTextCentered(quote, quotePerson, quotePersonPosition, null, null, quotePersonImg) mixin collinsQuote2 .card.card-dark-green-bg @@ -42,7 +43,7 @@ mixin collinsQuote2 -var quotePersonPosition = 'Associate Professor and Lab Director, Ontario Tech University' -var quotePersonImg = buildImgPath("advocates/collins.jpg") .card-body - +quoteLargeTextCentered(quote, quotePerson, quotePersonPosition, null, null, quotePersonImg, quotePerson) + +quoteLargeTextCentered(quote, quotePerson, quotePersonPosition, null, null, quotePersonImg) mixin bennettQuote1 .card.card-dark-green-bg @@ -51,4 +52,4 @@ mixin bennettQuote1 -var quotePersonPosition = 'Software Architect, Symplectic' -var quotePersonImg = buildImgPath("advocates/bennett.jpg") .card-body - +quoteLargeTextCentered(quote, quotePerson, quotePersonPosition, null, null, quotePersonImg, quotePerson) \ No newline at end of file + +quoteLargeTextCentered(quote, quotePerson, quotePersonPosition, null, null, quotePersonImg)