From 3d9e9f6aebb64b94211cfe292b0c2cfc54f46005 Mon Sep 17 00:00:00 2001
From: Jakob Ackermann <jakob.ackermann@overleaf.com>
Date: Tue, 29 Aug 2023 19:12:28 +0200
Subject: [PATCH] Merge pull request #14565 from overleaf/jpa-add-error-context

[web] add response context to errors of failed logout/login action in CI

GitOrigin-RevId: 9b2e23e243541f87476f8cc71687f9492f615b4d
---
 .../test/acceptance/src/helpers/UserHelper.js | 20 ++++++++++++++++---
 1 file changed, 17 insertions(+), 3 deletions(-)

diff --git a/services/web/test/acceptance/src/helpers/UserHelper.js b/services/web/test/acceptance/src/helpers/UserHelper.js
index f1e174abdb..ba35ba556d 100644
--- a/services/web/test/acceptance/src/helpers/UserHelper.js
+++ b/services/web/test/acceptance/src/helpers/UserHelper.js
@@ -142,7 +142,14 @@ class UserHelper {
       response.status !== 302 ||
       !response.headers.get('location').includes('/login')
     ) {
-      throw new Error('logout failed')
+      const body = await response.text()
+      throw new Error(
+        `logout failed: status=${response.status} body=${JSON.stringify(
+          body
+        )} headers=${JSON.stringify(
+          Object.fromEntries(response.headers.entries())
+        )}`
+      )
     }
     // after logout CSRF token becomes invalid
     this._csrfToken = ''
@@ -258,14 +265,21 @@ class UserHelper {
       }),
     })
     if (!response.ok) {
-      const error = new Error('login failed')
+      const body = await response.text()
+      const error = new Error(
+        `login failed: status=${response.status} body=${JSON.stringify(body)}`
+      )
       error.response = response
       throw error
     }
 
     const body = await response.json()
     if (body.redir !== '/project') {
-      const error = new Error('login failed')
+      const error = new Error(
+        `login should redirect to /project: status=${
+          response.status
+        } body=${JSON.stringify(body)}`
+      )
       error.response = response
       throw error
     }