From 3da66daa8bef3b28f36becbb7f2c4d79f6685e5c Mon Sep 17 00:00:00 2001
From: Rebeka Dekany <50901361+rebekadekany@users.noreply.github.com>
Date: Fri, 15 Sep 2023 09:13:11 +0200
Subject: [PATCH] Merge pull request #14792 from
 overleaf/rd-report-remove-li-element

Accessibility - use CSS instead of empty list item for spacing in the filetree

GitOrigin-RevId: 2ee330dc867c223394afa9ccce1017a79c7112c1
---
 .../js/features/file-tree/components/file-tree-root.js        | 4 +---
 .../js/features/history/components/history-file-tree.tsx      | 4 +---
 services/web/frontend/stylesheets/app/editor/file-tree.less   | 4 +++-
 .../web/frontend/stylesheets/app/editor/history-react.less    | 4 +++-
 4 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/services/web/frontend/js/features/file-tree/components/file-tree-root.js b/services/web/frontend/js/features/file-tree/components/file-tree-root.js
index 51799399fc..9d18e95df1 100644
--- a/services/web/frontend/js/features/file-tree/components/file-tree-root.js
+++ b/services/web/frontend/js/features/file-tree/components/file-tree-root.js
@@ -77,9 +77,7 @@ function FileTreeRootFolder() {
         dropRef={dropRef}
         isOver={isOver}
         dataTestId="file-tree-list-root"
-      >
-        <li className="bottom-buffer" />
-      </FileTreeFolderList>
+      />
     </>
   )
 }
diff --git a/services/web/frontend/js/features/history/components/history-file-tree.tsx b/services/web/frontend/js/features/history/components/history-file-tree.tsx
index 39cf775936..0f8adca1ef 100644
--- a/services/web/frontend/js/features/history/components/history-file-tree.tsx
+++ b/services/web/frontend/js/features/history/components/history-file-tree.tsx
@@ -30,8 +30,6 @@ export default function HistoryFileTree() {
       folders={mappedFileTree.folders}
       docs={mappedFileTree.docs ?? []}
       rootClassName="history-file-tree-list"
-    >
-      <li className="bottom-buffer" />
-    </HistoryFileTreeFolderList>
+    />
   )
 }
diff --git a/services/web/frontend/stylesheets/app/editor/file-tree.less b/services/web/frontend/stylesheets/app/editor/file-tree.less
index d6d928634e..689f456bc5 100644
--- a/services/web/frontend/stylesheets/app/editor/file-tree.less
+++ b/services/web/frontend/stylesheets/app/editor/file-tree.less
@@ -96,7 +96,9 @@
       margin-left: 22px;
     }
 
-    li.bottom-buffer {
+    &::after {
+      content: '';
+      display: block;
       min-height: @line-height-computed;
     }
 
diff --git a/services/web/frontend/stylesheets/app/editor/history-react.less b/services/web/frontend/stylesheets/app/editor/history-react.less
index efeae508c5..12cac4d6a6 100644
--- a/services/web/frontend/stylesheets/app/editor/history-react.less
+++ b/services/web/frontend/stylesheets/app/editor/history-react.less
@@ -432,7 +432,9 @@ history-root {
       margin-left: 22px;
     }
 
-    li.bottom-buffer {
+    &::after {
+      content: '';
+      display: block;
       min-height: @line-height-computed;
     }