From 3f388fb0ac4404ebe640b32923fd4ee284dab6c0 Mon Sep 17 00:00:00 2001 From: Brian Gough Date: Thu, 24 Mar 2016 11:37:57 +0000 Subject: [PATCH] only change ttl on cached packs, not temporary ones temporary = without versioning feature enabled cached = permanent versioned retrieved from s3 --- services/track-changes/app/coffee/PackManager.coffee | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/services/track-changes/app/coffee/PackManager.coffee b/services/track-changes/app/coffee/PackManager.coffee index d16b6857ce..1c54afdd3a 100644 --- a/services/track-changes/app/coffee/PackManager.coffee +++ b/services/track-changes/app/coffee/PackManager.coffee @@ -204,10 +204,12 @@ module.exports = PackManager = return callback(err) if err? if not pack? MongoAWS.unArchivePack project_id, doc_id, pack_id, callback - else if pack.expiresAt? + else if pack.expiresAt? and not pack.temporary # we only need to touch the TTL on the listing of changes in the project # because diffs on individual documents are always done after that PackManager.increaseTTL pack, callback + # only do this for cached packs, not temporary ones to avoid older packs + # being kept longer than newer ones (which messes up the last update version) else callback(null, pack)