agw/overleaf-cep
1
0
Fork 0
mirror of https://github.com/yu-i-i/overleaf-cep.git synced 2026-05-23 17:19:37 +02:00
Code Issues Packages Projects Releases Wiki Activity

[clsi] consolidate metrics for clsi-perf (#30746)

Browse Source 
* [clsi] remove all clsi-perf/health-check metrics

* [clsi] always emit E2E compile time metric

* [clsi] do not collect metrics for clsi-cache-template compiles

* [clsi] fix unit tests: request.metricsOpts always exists

* [clsi] use a gauge for the e2e compile time metric of clsi-perf

Co-authored-by: Eric Mc Sween <eric.mcsween@overleaf.com>

* [clsi] remove metrics for binary file downloads from clsi-perf

---------

Co-authored-by: Eric Mc Sween <eric.mcsween@overleaf.com>
GitOrigin-RevId: 7995512e57c802086350e3d1a0ec5213ecdf0a05
This commit is contained in:
Jakob Ackermann
2026-01-16 13:15:58 +00:00
committed by Copybot
parent e5a82e47ce
commit 3f9a7cf463
11 changed files with 105 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
services/clsi/test/unit/js/ResourceWriterTests.js
View File

@@ -246,6 +246,7 @@ describe('ResourceWriter', function () {
syncType: 'incremental',
syncState: (this.syncState = '1234567890abcdef'),
resources: this.resources,
metricsOpts: { path: 'foo' },
}
this.OutputFileFinder.findOutputFiles = sinon
.stub()

16
services/clsi/test/unit/js/StatsManagerTests.js
View File

@@ -85,7 +85,7 @@ describe('StatsManager', function () {
describe('sampleRequest', function () {
it('should return undefined if there is no user_id', function () {
const request = {}
const request = { metricsOpts: {} }
const percentage = 50
expect(sampleRequest(request, percentage)).to.be.undefined
})
@@ -127,23 +127,17 @@ describe('StatsManager', function () {
})
it('should return undefined if the sampling percentage is 0', function () {
const request = { user_id: 'some-user' }
const request = { user_id: 'some-user', metricsOpts: {} }
const percentage = 0
expect(sampleRequest(request, percentage)).to.be.undefined
})
it('should return undefined if the sampling percentage is negative', function () {
const request = { user_id: 'some-user' }
const request = { user_id: 'some-user', metricsOpts: {} }
const percentage = -10
expect(sampleRequest(request, percentage)).to.be.undefined
})
it('should sample if there are no metricsOpts', function () {
const request = { user_id: 'test-key-in' } // percentile 13
const percentage = 40
expect(sampleRequest(request, percentage)).to.be.true
})
it('should sample if metricsOpts has no path', function () {
const request = { user_id: 'test-key-in', metricsOpts: {} } // percentile 13
const percentage = 40
@@ -151,13 +145,13 @@ describe('StatsManager', function () {
})
it('should return true for a request that should be sampled', function () {
const request = { user_id: 'test-key-in' } // percentile 13
const request = { user_id: 'test-key-in', metricsOpts: {} } // percentile 13
const percentage = 40
expect(sampleRequest(request, percentage)).to.be.true
})
it('should return false for a request that should not be sampled', function () {
const request = { user_id: 'test-key-outer' } // percentile 47
const request = { user_id: 'test-key-outer', metricsOpts: {} } // percentile 47
const percentage = 40
expect(sampleRequest(request, percentage)).to.be.false
})