From 4183d0d1ab9c2711d65b4efe5cb7248c86f2abfe Mon Sep 17 00:00:00 2001 From: Jimmy Domagala-Tang Date: Mon, 18 Sep 2023 13:06:27 -0400 Subject: [PATCH] Merge pull request #14866 from overleaf/jdt-hist-rename-test fix: rename the history view split test so we can reroll it GitOrigin-RevId: fd42fab5b6fd715b89688b401596962453b1d002 --- services/web/app/src/Features/Project/ProjectController.js | 2 +- .../features/history/components/diff-view/toolbar/toolbar.tsx | 2 +- services/web/frontend/js/ide/history/HistoryV2Manager.js | 4 +++- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/services/web/app/src/Features/Project/ProjectController.js b/services/web/app/src/Features/Project/ProjectController.js index 1b4b59b0bf..bb79c5eb5a 100644 --- a/services/web/app/src/Features/Project/ProjectController.js +++ b/services/web/app/src/Features/Project/ProjectController.js @@ -702,7 +702,7 @@ const ProjectController = { SplitTestHandler.getAssignment( req, res, - 'history-view', + 'history-view-version', (error, assignment) => { // do not fail editor load if assignment fails if (error) { diff --git a/services/web/frontend/js/features/history/components/diff-view/toolbar/toolbar.tsx b/services/web/frontend/js/features/history/components/diff-view/toolbar/toolbar.tsx index c769285f8f..f9888595fa 100644 --- a/services/web/frontend/js/features/history/components/diff-view/toolbar/toolbar.tsx +++ b/services/web/frontend/js/features/history/components/diff-view/toolbar/toolbar.tsx @@ -19,7 +19,7 @@ export default function Toolbar({ diff, selection }: ToolbarProps) { return (
diff --git a/services/web/frontend/js/ide/history/HistoryV2Manager.js b/services/web/frontend/js/ide/history/HistoryV2Manager.js index 6a0825da73..330ff8082e 100644 --- a/services/web/frontend/js/ide/history/HistoryV2Manager.js +++ b/services/web/frontend/js/ide/history/HistoryV2Manager.js @@ -126,7 +126,9 @@ export default HistoryManager = (function () { } isReact() { - return getMeta('ol-splitTestVariants')?.['history-view'] === 'react' + return ( + getMeta('ol-splitTestVariants')?.['history-view-version'] === 'react' + ) } hardReset() {