From 4480a986a376a277bfd7b05a3ffebd4f3056b71a Mon Sep 17 00:00:00 2001 From: David <33458145+davidmcpowell@users.noreply.github.com> Date: Fri, 4 Oct 2024 10:15:31 +0100 Subject: [PATCH] Merge pull request #20785 from overleaf/dp-sticky-highlights Clear op highlight on review-panel-entry dismount GitOrigin-RevId: 9892df75f35fcb0440bd19bcfbaa276a3db033a1 --- .../components/review-panel-entry.tsx | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/services/web/frontend/js/features/review-panel-new/components/review-panel-entry.tsx b/services/web/frontend/js/features/review-panel-new/components/review-panel-entry.tsx index 1954baba52..c6b8937181 100644 --- a/services/web/frontend/js/features/review-panel-new/components/review-panel-entry.tsx +++ b/services/web/frontend/js/features/review-panel-new/components/review-panel-entry.tsx @@ -1,4 +1,4 @@ -import { FC, useCallback, useState } from 'react' +import { FC, useCallback, useEffect, useState } from 'react' import { AnyOperation } from '../../../../../types/change' import { useCodeMirrorStateContext, @@ -44,6 +44,15 @@ export const ReviewPanelEntry: FC<{ setFocused(true) }, [selectLineOnFocus, docId, openDocId, position]) + // Clear op highlight on dismount + useEffect(() => { + return () => { + if (hoverRanges) { + view.dispatch(clearHighlightRanges(op)) + } + } + }, []) // eslint-disable-line react-hooks/exhaustive-deps + return (