From 44cb381a4ddbea93d07b9f5e16c2d58107e059e8 Mon Sep 17 00:00:00 2001
From: Brian Gough <briangough@users.noreply.github.com>
Date: Thu, 11 Dec 2025 11:26:14 +0000
Subject: [PATCH] Merge pull request #30244 from
 overleaf/bg-add-missing-configuration-for-pdf-caching

add missing configuration for pdf caching

GitOrigin-RevId: b5791d5d6db7fc9e970acaa0ca9cc43e1a7ca8ec
---
 .../app/src/Features/Project/ProjectController.mjs  | 13 +++++++++++++
 services/web/config/settings.defaults.js            |  4 ----
 2 files changed, 13 insertions(+), 4 deletions(-)

diff --git a/services/web/app/src/Features/Project/ProjectController.mjs b/services/web/app/src/Features/Project/ProjectController.mjs
index 1d47042304..e868c54a5f 100644
--- a/services/web/app/src/Features/Project/ProjectController.mjs
+++ b/services/web/app/src/Features/Project/ProjectController.mjs
@@ -32,6 +32,7 @@ import Features from '../../infrastructure/Features.mjs'
 import BrandVariationsHandler from '../BrandVariations/BrandVariationsHandler.mjs'
 import UserController from '../User/UserController.mjs'
 import AnalyticsManager from '../Analytics/AnalyticsManager.mjs'
+import LocalsHelper from '../SplitTests/LocalsHelper.mjs'
 import SplitTestHandler from '../SplitTests/SplitTestHandler.mjs'
 import SplitTestSessionHandler from '../SplitTests/SplitTestSessionHandler.mjs'
 import FeaturesUpdater from '../Subscription/FeaturesUpdater.mjs'
@@ -581,6 +582,18 @@ const _ProjectController = {
         })
       )
 
+      // PDF caching, these tests are archived but we are keeping the frontend code unchanged for now
+      LocalsHelper.setSplitTestVariant(
+        res.locals,
+        'pdf-caching-cached-url-lookup',
+        Settings.cachedUrlLookupEnabled ? 'enabled' : 'disabled'
+      )
+      LocalsHelper.setSplitTestVariant(
+        res.locals,
+        'pdf-caching-mode',
+        Settings.pdfCachingMode ? 'enabled' : 'disabled'
+      )
+
       const brandVariation = project?.brandVariationId
         ? await BrandVariationsHandler.promises.getBrandVariationById(
             project.brandVariationId
diff --git a/services/web/config/settings.defaults.js b/services/web/config/settings.defaults.js
index 419b2d0ff9..9bdaf93192 100644
--- a/services/web/config/settings.defaults.js
+++ b/services/web/config/settings.defaults.js
@@ -703,10 +703,6 @@ module.exports = {
   // By default turn on feature flag, can be overridden per request.
   enablePdfCaching: process.env.ENABLE_PDF_CACHING === 'true',
 
-  pdfCachingMinChunkSize: 7500,
-  pdfCaching: true,
-  cachedUrlLookupEnabled: true,
-
   // Maximum size of text documents in the real-time editing system.
   max_doc_length: 2 * 1024 * 1024, // 2mb