From 46c7341cf8530956501e7a4f7abc559534b0f3ab Mon Sep 17 00:00:00 2001
From: Domagoj Kriskovic <dom.kriskovic@overleaf.com>
Date: Mon, 14 Apr 2025 11:00:01 +0200
Subject: [PATCH] Update share modal copy for reviewer role (#24694)

* Update share modal copy for reviewer role

* fix ShareProjectModal test

* use "limited_to_n_collaborators_per_project"

GitOrigin-RevId: f5afcb18a3921a6b1132a4c323af9d8395a7d07b
---
 .../web/frontend/extracted-translations.json  | 24 +++++++++----------
 .../components/access-levels-changed.tsx      |  6 ++---
 .../collaborators-limit-upgrade.tsx           |  6 +++--
 .../components/edit-member.tsx                |  4 ++--
 .../components/send-invites-notice.tsx        | 10 +++++---
 .../view-only-access-modal-content.tsx        |  4 ++--
 services/web/locales/en.json                  | 24 +++++++++----------
 .../components/share-project-modal.test.jsx   |  8 +++----
 8 files changed, 44 insertions(+), 42 deletions(-)

diff --git a/services/web/frontend/extracted-translations.json b/services/web/frontend/extracted-translations.json
index 4eadb9b175..77457ed74d 100644
--- a/services/web/frontend/extracted-translations.json
+++ b/services/web/frontend/extracted-translations.json
@@ -73,7 +73,7 @@
   "add_error_assist_annual_to_your_projects": "",
   "add_error_assist_to_your_projects": "",
   "add_files": "",
-  "add_more_editors": "",
+  "add_more_collaborators": "",
   "add_more_licenses_to_my_plan": "",
   "add_more_managers": "",
   "add_new_email": "",
@@ -903,11 +903,9 @@
   "licenses": "",
   "limited_document_history": "",
   "limited_offer": "",
+  "limited_to_n_collaborators_per_project": "",
+  "limited_to_n_collaborators_per_project_plural": "",
   "limited_to_n_editors": "",
-  "limited_to_n_editors_or_reviewers": "",
-  "limited_to_n_editors_or_reviewers_per_project": "",
-  "limited_to_n_editors_or_reviewers_per_project_plural": "",
-  "limited_to_n_editors_or_reviewers_plural": "",
   "limited_to_n_editors_per_project": "",
   "limited_to_n_editors_per_project_plural": "",
   "limited_to_n_editors_plural": "",
@@ -1190,7 +1188,7 @@
   "pick_up_where_you_left_off": "",
   "plan": "",
   "plan_tooltip": "",
-  "please_ask_the_project_owner_to_upgrade_more_editors": "",
+  "please_ask_the_project_owner_to_upgrade_more_collaborators": "",
   "please_ask_the_project_owner_to_upgrade_to_track_changes": "",
   "please_change_primary_to_remove": "",
   "please_check_your_inbox_to_confirm": "",
@@ -1733,10 +1731,10 @@
   "this_is_a_labs_experiment_for_the_new_overleaf_editor_some_features_are_still_in_progress": "",
   "this_is_a_new_feature": "",
   "this_is_the_file_that_references_pulled_from_your_reference_manager_will_be_added_to": "",
-  "this_project_already_has_maximum_editors": "",
+  "this_project_already_has_maximum_collaborators": "",
   "this_project_contains_a_file_called_output": "",
+  "this_project_exceeded_collaborator_limit": "",
   "this_project_exceeded_compile_timeout_limit_on_free_plan": "",
-  "this_project_exceeded_editor_limit": "",
   "this_project_has_more_than_max_collabs": "",
   "this_project_is_public": "",
   "this_project_is_public_read_only": "",
@@ -1923,7 +1921,7 @@
   "upgrade_now": "",
   "upgrade_plan": "",
   "upgrade_summary": "",
-  "upgrade_to_add_more_editors_and_access_collaboration_features": "",
+  "upgrade_to_add_more_collaborators_and_access_collaboration_features": "",
   "upgrade_to_get_feature": "",
   "upgrade_to_review": "",
   "upgrade_to_track_changes": "",
@@ -2069,8 +2067,8 @@
   "you_can_now_enable_sso": "",
   "you_can_now_log_in_sso": "",
   "you_can_request_a_maximum_of_limit_fixes_per_day": "",
-  "you_can_select_or_invite": "",
-  "you_can_select_or_invite_plural": "",
+  "you_can_select_or_invite_collaborator": "",
+  "you_can_select_or_invite_collaborator_plural": "",
   "you_can_still_use_your_premium_features": "",
   "you_cant_add_or_change_password_due_to_sso": "",
   "you_cant_join_this_group_subscription": "",
@@ -2118,8 +2116,8 @@
   "your_plan_is_limited_to_n_editors": "",
   "your_plan_is_limited_to_n_editors_plural": "",
   "your_premium_plan_is_paused": "",
+  "your_project_exceeded_collaborator_limit": "",
   "your_project_exceeded_compile_timeout_limit_on_free_plan": "",
-  "your_project_exceeded_editor_limit": "",
   "your_project_near_compile_timeout_limit": "",
   "your_project_need_more_time_to_compile": "",
   "your_projects": "",
@@ -2140,7 +2138,7 @@
   "youre_signed_in_as_logout": "",
   "youve_added_more_licenses": "",
   "youve_added_x_more_licenses_to_your_subscription_invite_people": "",
-  "youve_lost_edit_access": "",
+  "youve_lost_collaboration_access": "",
   "youve_paused_your_subscription": "",
   "youve_unlinked_all_users": "",
   "youve_upgraded_your_plan": "",
diff --git a/services/web/frontend/js/features/share-project-modal/components/access-levels-changed.tsx b/services/web/frontend/js/features/share-project-modal/components/access-levels-changed.tsx
index e0ac152a58..37c9259b73 100644
--- a/services/web/frontend/js/features/share-project-modal/components/access-levels-changed.tsx
+++ b/services/web/frontend/js/features/share-project-modal/components/access-levels-changed.tsx
@@ -29,11 +29,11 @@ export default function AccessLevelsChanged({
         }
         content={
           somePendingEditorsResolved ? (
-            <p>{t('your_project_exceeded_editor_limit')}</p>
+            <p>{t('your_project_exceeded_collaborator_limit')}</p>
           ) : (
             <p>
-              {t('this_project_exceeded_editor_limit')}{' '}
-              {t('you_can_select_or_invite', {
+              {t('this_project_exceeded_collaborator_limit')}{' '}
+              {t('you_can_select_or_invite_collaborator', {
                 count: features.collaborators,
               })}
             </p>
diff --git a/services/web/frontend/js/features/share-project-modal/components/collaborators-limit-upgrade.tsx b/services/web/frontend/js/features/share-project-modal/components/collaborators-limit-upgrade.tsx
index 450e42669d..4b63c63e08 100644
--- a/services/web/frontend/js/features/share-project-modal/components/collaborators-limit-upgrade.tsx
+++ b/services/web/frontend/js/features/share-project-modal/components/collaborators-limit-upgrade.tsx
@@ -15,10 +15,12 @@ export default function CollaboratorsLimitUpgrade() {
       <Notification
         type="info"
         customIcon={<img src={addMoreEditorsImage} alt="" aria-hidden="true" />}
-        title={t('add_more_editors')}
+        title={t('add_more_collaborators')}
         content={
           <p>
-            {t('upgrade_to_add_more_editors_and_access_collaboration_features')}
+            {t(
+              'upgrade_to_add_more_collaborators_and_access_collaboration_features'
+            )}
           </p>
         }
         isActionBelowContent
diff --git a/services/web/frontend/js/features/share-project-modal/components/edit-member.tsx b/services/web/frontend/js/features/share-project-modal/components/edit-member.tsx
index 5b7ac58fd7..45a04dd99c 100644
--- a/services/web/frontend/js/features/share-project-modal/components/edit-member.tsx
+++ b/services/web/frontend/js/features/share-project-modal/components/edit-member.tsx
@@ -286,7 +286,7 @@ function SelectPrivilege({
 
     if (hasBeenDowngraded) {
       if (isSplitTestEnabled('reviewer-role')) {
-        return t('limited_to_n_editors_or_reviewers', {
+        return t('limited_to_n_collaborators_per_project', {
           count: features.collaborators,
         })
       } else {
@@ -297,7 +297,7 @@ function SelectPrivilege({
       !['readAndWrite', 'review'].includes(value)
     ) {
       if (isSplitTestEnabled('reviewer-role')) {
-        return t('limited_to_n_editors_or_reviewers_per_project', {
+        return t('limited_to_n_collaborators_per_project', {
           count: features.collaborators,
         })
       } else {
diff --git a/services/web/frontend/js/features/share-project-modal/components/send-invites-notice.tsx b/services/web/frontend/js/features/share-project-modal/components/send-invites-notice.tsx
index 5efe27d443..c7417db158 100644
--- a/services/web/frontend/js/features/share-project-modal/components/send-invites-notice.tsx
+++ b/services/web/frontend/js/features/share-project-modal/components/send-invites-notice.tsx
@@ -17,11 +17,15 @@ export default function SendInvitesNotice() {
         <Notification
           isActionBelowContent
           type="info"
-          title={t('youve_lost_edit_access')}
+          title={t('youve_lost_collaboration_access')}
           content={
             <div>
-              <p>{t('this_project_already_has_maximum_editors')}</p>
-              <p>{t('please_ask_the_project_owner_to_upgrade_more_editors')}</p>
+              <p>{t('this_project_already_has_maximum_collaborators')}</p>
+              <p>
+                {t(
+                  'please_ask_the_project_owner_to_upgrade_more_collaborators'
+                )}
+              </p>
             </div>
           }
         />
diff --git a/services/web/frontend/js/features/share-project-modal/components/view-only-access-modal-content.tsx b/services/web/frontend/js/features/share-project-modal/components/view-only-access-modal-content.tsx
index 622e8c859e..7fb3de5e74 100644
--- a/services/web/frontend/js/features/share-project-modal/components/view-only-access-modal-content.tsx
+++ b/services/web/frontend/js/features/share-project-modal/components/view-only-access-modal-content.tsx
@@ -24,8 +24,8 @@ export default function ViewOnlyAccessModalContent({
       </OLModalHeader>
 
       <OLModalBody>
-        <p>{t('this_project_already_has_maximum_editors')}</p>
-        <p>{t('please_ask_the_project_owner_to_upgrade_more_editors')}</p>
+        <p>{t('this_project_already_has_maximum_collaborators')}</p>
+        <p>{t('please_ask_the_project_owner_to_upgrade_more_collaborators')}</p>
       </OLModalBody>
       <OLModalFooter>
         <OLButton
diff --git a/services/web/locales/en.json b/services/web/locales/en.json
index 776b4ae0df..ed8b473dda 100644
--- a/services/web/locales/en.json
+++ b/services/web/locales/en.json
@@ -88,7 +88,7 @@
   "add_error_assist_annual_to_your_projects": "Add Error Assist Annual <sparkle/> to your projects and get unlimited AI help to fix LaTeX errors faster.",
   "add_error_assist_to_your_projects": "Add Error Assist <sparkle/> to your projects and get unlimited AI help to fix LaTeX errors faster.",
   "add_files": "Add Files",
-  "add_more_editors": "Add more editors",
+  "add_more_collaborators": "Add more collaborators",
   "add_more_licenses_to_my_plan": "Add more licenses to my plan",
   "add_more_managers": "Add more managers",
   "add_new_email": "Add new email",
@@ -1184,11 +1184,9 @@
   "license": "License",
   "licenses": "Licenses",
   "limited_document_history": "Limited document history",
+  "limited_to_n_collaborators_per_project": "Limited to __count__ collaborator per project",
+  "limited_to_n_collaborators_per_project_plural": "Limited to __count__ collaborators per project",
   "limited_to_n_editors": "Limited to __count__ editor",
-  "limited_to_n_editors_or_reviewers": "Limited to __count__ editor or reviewer",
-  "limited_to_n_editors_or_reviewers_per_project": "Limited to __count__ editor or reviewer per project",
-  "limited_to_n_editors_or_reviewers_per_project_plural": "Limited to __count__ editors or reviewers per project",
-  "limited_to_n_editors_or_reviewers_plural": "Limited to __count__ editors or reviewers",
   "limited_to_n_editors_per_project": "Limited to __count__ editor per project",
   "limited_to_n_editors_per_project_plural": "Limited to __count__ editors per project",
   "limited_to_n_editors_plural": "Limited to __count__ editors",
@@ -1591,7 +1589,7 @@
   "plans_amper_pricing": "Plans & Pricing",
   "plans_and_pricing": "Plans and Pricing",
   "plans_and_pricing_lowercase": "plans and pricing",
-  "please_ask_the_project_owner_to_upgrade_more_editors": "Please ask the project owner to upgrade their plan to allow more editors.",
+  "please_ask_the_project_owner_to_upgrade_more_collaborators": "Please ask the project owner to upgrade their plan to allow more collaborators.",
   "please_ask_the_project_owner_to_upgrade_to_track_changes": "Please ask the project owner to upgrade to use track changes",
   "please_change_primary_to_remove": "Please change your primary email in order to remove",
   "please_check_your_inbox_to_confirm": "Please check your email inbox to confirm your <0>__institutionName__</0> affiliation.",
@@ -2259,10 +2257,10 @@
   "this_is_a_new_feature": "This is a new feature",
   "this_is_the_file_that_references_pulled_from_your_reference_manager_will_be_added_to": "This is the file that references pulled from your reference manager will be added to.",
   "this_is_your_template": "This is your template from your project",
-  "this_project_already_has_maximum_editors": "This project already has the maximum number of editors permitted on the owner’s plan. This means you can view but not edit the project.",
+  "this_project_already_has_maximum_collaborators": "This project already has the maximum number of collaborators permitted on the owner’s plan. This means you can view but not edit or review the project.",
   "this_project_contains_a_file_called_output": "This project contains a file called output.pdf. If that file exists, please rename it and compile again.",
+  "this_project_exceeded_collaborator_limit": "This project exceeded the collaborator limit for your plan. All other users now have view-only access.",
   "this_project_exceeded_compile_timeout_limit_on_free_plan": "This project exceeded the compile timeout limit on our free plan.",
-  "this_project_exceeded_editor_limit": "This project exceeded the editor limit for your plan. All collaborators now have view-only access.",
   "this_project_has_more_than_max_collabs": "This project has more than the maximum number of collaborators allowed on the project owner’s Overleaf plan. This means you could lose edit access from __linkSharingDate__.",
   "this_project_is_public": "This project is public and can be edited by anyone with the URL.",
   "this_project_is_public_read_only": "This project is public and can be viewed but not edited by anyone with the URL",
@@ -2460,7 +2458,7 @@
   "upgrade_now": "Upgrade now",
   "upgrade_plan": "Upgrade plan",
   "upgrade_summary": "Upgrade summary",
-  "upgrade_to_add_more_editors_and_access_collaboration_features": "Upgrade to add more editors and access collaboration features like track changes and full project history.",
+  "upgrade_to_add_more_collaborators_and_access_collaboration_features": "Upgrade to add more collaborators and access collaboration features like track changes and full project history.",
   "upgrade_to_get_feature": "Upgrade to get __feature__, plus:",
   "upgrade_to_review": "Upgrade to Review",
   "upgrade_to_track_changes": "Upgrade to track changes",
@@ -2626,8 +2624,8 @@
   "you_can_now_log_in_sso": "You can now log in through your institution and if eligible you will receive <0>__appName__ Professional features</0>.",
   "you_can_opt_in_and_out_of_the_program_at_any_time_on_this_page": "You can <0>opt in and out</0> of the program at any time on this page",
   "you_can_request_a_maximum_of_limit_fixes_per_day": "You can request a maximum of __limit__ fixes per day. Please try again tomorrow.",
-  "you_can_select_or_invite": "You can select or invite __count__ editor on your current plan, or upgrade to get more.",
-  "you_can_select_or_invite_plural": "You can select or invite __count__ editors on your current plan, or upgrade to get more.",
+  "you_can_select_or_invite_collaborator": "You can select or invite __count__ collaborator on your current plan. Upgrade to add more editors or reviewers.",
+  "you_can_select_or_invite_collaborator_plural": "You can select or invite __count__ collaborators on your current plan. Upgrade to add more editors or reviewers.",
   "you_can_still_use_your_premium_features": "You can still use your premium features until the pause becomes active.",
   "you_cant_add_or_change_password_due_to_sso": "You can’t add or change your password because your group or organization uses <0>single sign-on (SSO)</0>.",
   "you_cant_join_this_group_subscription": "You can’t join this group subscription",
@@ -2679,8 +2677,8 @@
   "your_plan_is_limited_to_n_editors": "Your plan allows __count__ collaborator with edit access and unlimited viewers.",
   "your_plan_is_limited_to_n_editors_plural": "Your plan allows __count__ collaborators with edit access and unlimited viewers.",
   "your_premium_plan_is_paused": "Your Premium plan is <0>paused</0>.",
+  "your_project_exceeded_collaborator_limit": "Your project exceeded the collaborator limit and access levels were changed. Select a new access level for your collaborators, or upgrade to add more editors or reviewers.",
   "your_project_exceeded_compile_timeout_limit_on_free_plan": "Your project exceeded the compile timeout limit on our free plan.",
-  "your_project_exceeded_editor_limit": "Your project exceeded the editor limit and access levels were changed. Select a new access level for your collaborators, or upgrade to add more editors.",
   "your_project_near_compile_timeout_limit": "Your project is near the compile timeout limit for our free plan.",
   "your_project_need_more_time_to_compile": "It looks like your project may need more time to compile than our free plan allows.",
   "your_projects": "Your Projects",
@@ -2704,7 +2702,7 @@
   "youre_signed_up": "You’re signed up",
   "youve_added_more_licenses": "You’ve added more license(s)!",
   "youve_added_x_more_licenses_to_your_subscription_invite_people": "You’ve added __users__ more license(s) to your subscription. <0>Invite people</0>.",
-  "youve_lost_edit_access": "You’ve lost edit access",
+  "youve_lost_collaboration_access": "You’ve lost collaboration access",
   "youve_paused_your_subscription": "Your <0>__planName__</0> subscription is paused until <0>__reactivationDate__</0>, then it’ll automatically unpause. You can unpause early at any time.",
   "youve_unlinked_all_users": "You’ve unlinked all users",
   "youve_upgraded_your_plan": "You’ve upgraded your plan!",
diff --git a/services/web/test/frontend/features/share-project-modal/components/share-project-modal.test.jsx b/services/web/test/frontend/features/share-project-modal/components/share-project-modal.test.jsx
index 611666714f..0ecacfe5b2 100644
--- a/services/web/test/frontend/features/share-project-modal/components/share-project-modal.test.jsx
+++ b/services/web/test/frontend/features/share-project-modal/components/share-project-modal.test.jsx
@@ -686,7 +686,7 @@ describe('<ShareProjectModal/>', function () {
       },
     })
 
-    await screen.findByText('Add more editors')
+    await screen.findByText('Add more collaborators')
 
     const user = userEvent.setup()
     await user.click(screen.getByTestId('add-collaborator-select'))
@@ -699,7 +699,7 @@ describe('<ShareProjectModal/>', function () {
     expect(viewerOption.classList.contains('disabled')).to.be.false
 
     screen.getByText(
-      /Upgrade to add more editors and access collaboration features like track changes and full project history/
+      /Upgrade to add more collaborators and access collaboration features like track changes and full project history/
     )
   })
 
@@ -722,7 +722,7 @@ describe('<ShareProjectModal/>', function () {
       },
     })
 
-    await screen.findByText('Add more editors')
+    await screen.findByText('Add more collaborators')
 
     const user = userEvent.setup()
     await user.click(screen.getByTestId('add-collaborator-select'))
@@ -736,7 +736,7 @@ describe('<ShareProjectModal/>', function () {
     expect(viewerOption.classList.contains('disabled')).to.be.false
 
     screen.getByText(
-      /Upgrade to add more editors and access collaboration features like track changes and full project history/
+      /Upgrade to add more collaborators and access collaboration features like track changes and full project history/
     )
   })