Merge pull request #6727 from overleaf/em-revert-logs-ui-split-test

Revert "Move new logs UI toggle to a split test"

GitOrigin-RevId: 5f2aecb53d2df21c89da594b0a64c8cf8ca04bc6
This commit is contained in:
Eric Mc Sween
2022-02-11 09:39:05 -05:00
committed by Copybot
parent 4df657db4b
commit 46d2b84103
7 changed files with 230 additions and 24 deletions
@@ -36,6 +36,7 @@ const UserController = require('../User/UserController')
const AnalyticsManager = require('../Analytics/AnalyticsManager')
const Modules = require('../../infrastructure/Modules')
const SplitTestHandler = require('../SplitTests/SplitTestHandler')
const { getNewLogsUIVariantForUser } = require('../Helpers/NewLogsUI')
const FeaturesUpdater = require('../Subscription/FeaturesUpdater')
const SpellingHandler = require('../Spelling/SpellingHandler')
const UserPrimaryEmailCheckHandler = require('../User/UserPrimaryEmailCheckHandler')
@@ -828,21 +829,6 @@ const ProjectController = {
}
)
},
logsUIAssignment(cb) {
SplitTestHandler.getAssignment(
req,
'logs-ui',
{},
(error, assignment) => {
// do not fail editor load if assignment fails
if (error) {
cb(null, { variant: 'default' })
} else {
cb(null, assignment)
}
}
)
},
},
(
err,
@@ -856,7 +842,6 @@ const ProjectController = {
newPdfPreviewAssignment,
newSourceEditorAssignment,
pdfDetachAssignment,
logsUIAssignment,
}
) => {
if (err != null) {
@@ -921,6 +906,8 @@ const ProjectController = {
})
}
const logsUIVariant = getNewLogsUIVariantForUser(user)
function shouldDisplayFeature(name, variantFlag) {
if (req.query && req.query[name]) {
return req.query[name] === 'true'
@@ -1017,7 +1004,11 @@ const ProjectController = {
gitBridgePublicBaseUrl: Settings.gitBridgePublicBaseUrl,
wsUrl,
showSupport: Features.hasFeature('support'),
logsUIVariant: logsUIAssignment.variant,
showNewLogsUI: shouldDisplayFeature(
'new_logs_ui',
logsUIVariant.newLogsUI
),
logsUISubvariant: logsUIVariant.subvariant,
showPdfDetach,
debugPdfDetach,
showNewPdfPreview,