agw/overleaf-cep
1
0
Fork 0
mirror of https://github.com/yu-i-i/overleaf-cep.git synced 2026-11-14 22:23:42 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #29971 from overleaf/mg-edit-search-bug

Browse Source 
Make editor focusable in view-only mode

GitOrigin-RevId: ed9b079fa379d84f7f410669fa2d865f82e21cb1
This commit is contained in:
Malik Glossop
2025-12-02 09:04:59 +00:00
committed by Copybot
parent dab59520c3
commit 472e05f32b
3 changed files with 209 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
services/web/test/frontend/features/source-editor/components/codemirror-editor-visual-readonly.spec.tsx
+53
View File
@@ -8,6 +8,7 @@ import { FC } from 'react'
import { FileTreePathContext } from '@/features/file-tree/contexts/file-tree-path'
import { TestContainer } from '../helpers/test-container'
import { PermissionsContext } from '@/features/ide-react/context/permissions-context'
import { metaKey } from '../helpers/meta-key'
const FileTreePathProvider: FC<React.PropsWithChildren> = ({ children }) => (
<FileTreePathContext.Provider
@@ -154,4 +155,56 @@ describe('<CodeMirrorEditor/> in Visual mode with read-only permission', functio
cy.findByLabelText('URL').should('be.disabled')
cy.findByRole('button', { name: 'Remove link' }).should('not.exist')
})
it('opens the CodeMirror search panel with Cmd/Ctrl+F', function () {
mountEditor('Hello world\n\nThis is a test document.')
// Click to focus the editor
cy.get('.cm-content').click()
// Search panel should not be open initially
cy.findByRole('search').should('not.exist')
// Press Cmd/Ctrl+F to open search
cy.get('.cm-content').type(`{${metaKey}+f}`)
// Search panel should now be open
cy.findByRole('search').should('exist')
cy.findByRole('textbox', { name: 'Find' }).should('be.visible')
})
it('allows searching for text in read-only mode', function () {
mountEditor('Hello world\n\nThis is a test document with hello again.')
// Click to focus the editor
cy.get('.cm-content').click()
// Open search panel
cy.get('.cm-content').type(`{${metaKey}+f}`)
// Type a search query
cy.findByRole('textbox', { name: 'Find' }).type('hello')
// Should find matches (case insensitive)
cy.get('.cm-searchMatch').should('have.length.at.least', 1)
})
it('closes the search panel with Escape', function () {
mountEditor('Hello world')
// Click to focus the editor
cy.get('.cm-content').click()
// Open search panel
cy.get('.cm-content').type(`{${metaKey}+f}`)
// Search panel should be open
cy.findByRole('search').should('exist')
// Press Escape to close
cy.findByRole('textbox', { name: 'Find' }).type('{esc}')
// Search panel should be closed
cy.findByRole('search').should('not.exist')
})
})