From 47937c4073fc7280cbef9b72f0f54ede76310cb1 Mon Sep 17 00:00:00 2001 From: M Fahru Date: Wed, 15 Feb 2023 09:32:31 -0700 Subject: [PATCH] Fix event "left-menu-documentation-click" not being fired properly (#11836) GitOrigin-RevId: 5e9df12c699ff5c25389e8fb90fda73913e8c747 --- services/web/app/views/project/editor/left-menu.pug | 6 ++---- .../controllers/left-menu-documentation-controller.js | 10 ++++++++++ services/web/frontend/js/ide/settings/index.js | 1 + 3 files changed, 13 insertions(+), 4 deletions(-) create mode 100644 services/web/frontend/js/features/editor-left-menu/controllers/left-menu-documentation-controller.js diff --git a/services/web/app/views/project/editor/left-menu.pug b/services/web/app/views/project/editor/left-menu.pug index 26fd8e1b97..60c1ee6e61 100644 --- a/services/web/app/views/project/editor/left-menu.pug +++ b/services/web/app/views/project/editor/left-menu.pug @@ -237,12 +237,10 @@ aside#left-menu.full-size( new-source-editor="editor.newSourceEditor" ) if showSupport - li + li(ng-controller="LeftMenuDocumentationController") a( href='/learn', target="_blank" - event-tracking="left-menu-documentation-click " - event-tracking-mb="true" - event-tracking-trigger="click" + ng-click="sendLeftMenuDocumentationEvent()" ) i.fa.fa-book.fa-fw |    #{translate('documentation')} diff --git a/services/web/frontend/js/features/editor-left-menu/controllers/left-menu-documentation-controller.js b/services/web/frontend/js/features/editor-left-menu/controllers/left-menu-documentation-controller.js new file mode 100644 index 0000000000..7f0d4798fb --- /dev/null +++ b/services/web/frontend/js/features/editor-left-menu/controllers/left-menu-documentation-controller.js @@ -0,0 +1,10 @@ +import App from '../../../base' + +export default App.controller( + 'LeftMenuDocumentationController', + function ($scope, eventTracking) { + $scope.sendLeftMenuDocumentationEvent = () => { + eventTracking.sendMB('left-menu-documentation-click') + } + } +) diff --git a/services/web/frontend/js/ide/settings/index.js b/services/web/frontend/js/ide/settings/index.js index b0459b687c..1cde1c72db 100644 --- a/services/web/frontend/js/ide/settings/index.js +++ b/services/web/frontend/js/ide/settings/index.js @@ -4,3 +4,4 @@ import './services/settings' import './controllers/SettingsController' import '../../features/dictionary/controllers/modal-controller' import '../../features/editor-left-menu/controllers/editor-left-menu-controller' +import '../../features/editor-left-menu/controllers/left-menu-documentation-controller'