From 48b5c7e209e8ada0d1008b813e9d63c8b1337cea Mon Sep 17 00:00:00 2001 From: Ersun Warncke Date: Thu, 6 Jun 2019 08:43:49 -0400 Subject: [PATCH] do not log warning in dev/tests (#1830) do not log warning in dev/tests GitOrigin-RevId: c46664779fe939ad0f39466f43eb24381a245b55 --- .../app/src/Features/Analytics/AnalyticsManager.js | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/services/web/app/src/Features/Analytics/AnalyticsManager.js b/services/web/app/src/Features/Analytics/AnalyticsManager.js index e076db0d2b..ee212ea513 100644 --- a/services/web/app/src/Features/Analytics/AnalyticsManager.js +++ b/services/web/app/src/Features/Analytics/AnalyticsManager.js @@ -19,6 +19,10 @@ const _ = require('underscore') const request = require('requestretry') const Errors = require('../Errors/Errors') +const isProduction = + (process.env['NODE_ENV'] || '').toLowerCase() === 'production' +const isTest = process.env['MOCHA_GREP'] !== undefined + const makeFaultTolerantRequest = function(userId, options, callback) { if ( userId + '' === @@ -76,10 +80,12 @@ var exponentialBackoffStrategy = function() { var exponentialBackoffDelay = function(attempts) { const delay = Math.pow(2, attempts) * 1000 - logger.warn( - 'Error comunicating with the analytics service. ' + - `Will try again attempt ${attempts} in ${delay}ms` - ) + if (isProduction && !isTest) { + logger.warn( + 'Error comunicating with the analytics service. ' + + `Will try again attempt ${attempts} in ${delay}ms` + ) + } return delay }