From 4b14a148197cc4e2c679b5c62ca798b086dc7d12 Mon Sep 17 00:00:00 2001 From: June Kelly Date: Thu, 3 Feb 2022 09:37:55 +0000 Subject: [PATCH] Merge pull request #6573 from overleaf/jk-cm6-heartbeat [web] Move on-scroll heartbeat tracking from ace to IDE GitOrigin-RevId: e39bc9ebffde228c4a2d6045837fae3b64219bed --- services/web/frontend/js/ide.js | 1 + services/web/frontend/js/ide/editor/directives/aceEditor.js | 2 -- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/services/web/frontend/js/ide.js b/services/web/frontend/js/ide.js index 8b430dd61e..549b65a1de 100644 --- a/services/web/frontend/js/ide.js +++ b/services/web/frontend/js/ide.js @@ -257,6 +257,7 @@ If the project has been renamed please look in your project list for a new proje }) $scope.$on('cursor:editor:update', eventTracking.editingSessionHeartbeat) + $scope.$on('scroll:editor:update', eventTracking.editingSessionHeartbeat) const DARK_THEMES = [ 'ambiance', diff --git a/services/web/frontend/js/ide/editor/directives/aceEditor.js b/services/web/frontend/js/ide/editor/directives/aceEditor.js index b0bb24d937..017eb7eb8a 100644 --- a/services/web/frontend/js/ide/editor/directives/aceEditor.js +++ b/services/web/frontend/js/ide/editor/directives/aceEditor.js @@ -818,8 +818,6 @@ App.directive( // deletes and then inserts document content session.setAnnotations(scope.annotations) - session.on('changeScrollTop', eventTracking.editingSessionHeartbeat) - angular .element($window) .on('click', eventTracking.editingSessionHeartbeat)