From 4f1168a590c8cd9767e3baa764490e5f1f48fb7c Mon Sep 17 00:00:00 2001 From: Shane Kilkelly Date: Wed, 9 Jan 2019 14:24:04 +0000 Subject: [PATCH] Add comments pointing to github issue --- .../ac/ic/wlgitbridge/bridge/snapshot/SnapshotApiFacade.java | 3 +++ .../uk/ac/ic/wlgitbridge/snapshot/getdoc/GetDocResult.java | 3 +++ 2 files changed, 6 insertions(+) diff --git a/services/git-bridge/src/main/java/uk/ac/ic/wlgitbridge/bridge/snapshot/SnapshotApiFacade.java b/services/git-bridge/src/main/java/uk/ac/ic/wlgitbridge/bridge/snapshot/SnapshotApiFacade.java index 6f07b7e924..9aa3165e06 100644 --- a/services/git-bridge/src/main/java/uk/ac/ic/wlgitbridge/bridge/snapshot/SnapshotApiFacade.java +++ b/services/git-bridge/src/main/java/uk/ac/ic/wlgitbridge/bridge/snapshot/SnapshotApiFacade.java @@ -97,6 +97,9 @@ public class SnapshotApiFacade { = api.getSavedVers(oauth2, projectName); GetDocResult latestDoc = SnapshotApi.getResult(getDoc); int latest = latestDoc.getVersionID(); + // Handle edge-case for projects with no changes, that were imported + // to v2. In which case both `latest` and `version` will be zero. + // See: https://github.com/overleaf/writelatex-git-bridge/pull/50 if (latest > version || (latest == 0 && version == 0)) { for ( SnapshotInfo snapshotInfo : diff --git a/services/git-bridge/src/main/java/uk/ac/ic/wlgitbridge/snapshot/getdoc/GetDocResult.java b/services/git-bridge/src/main/java/uk/ac/ic/wlgitbridge/snapshot/getdoc/GetDocResult.java index f95a5c6619..bfb659769a 100644 --- a/services/git-bridge/src/main/java/uk/ac/ic/wlgitbridge/snapshot/getdoc/GetDocResult.java +++ b/services/git-bridge/src/main/java/uk/ac/ic/wlgitbridge/snapshot/getdoc/GetDocResult.java @@ -98,6 +98,9 @@ public class GetDocResult extends Result { } } else { versionID = jsonObject.get("latestVerId").getAsInt(); + // Handle edge-case for projects with no changes, that were imported + // to v2. In which case `latestVerAt` will not be present. + // See: https://github.com/overleaf/writelatex-git-bridge/pull/50 if (jsonObject.has("latestVerAt")) { createdAt = jsonObject.get("latestVerAt").getAsString(); } else {