Merge pull request #13223 from overleaf/ae-typescript-upgrade

Upgrade TypeScript to v5

GitOrigin-RevId: 55d98c0e8fdeb39c1297b4472f0d604e25af995b

services/web/frontend/js/features/user-content-domain-access-check/index.ts

@@ -267,6 +267,7 @@ window.addEventListener('online', () => {
 try {
   // Note: navigator.connection is not available on Firefox and Safari.
   // Docs: https://developer.mozilla.org/en-US/docs/Web/API/NetworkInformation
+  // @ts-ignore
   navigator.connection.addEventListener('change', () => {
     // The network changed. Schedule another check for it.
     accessCheckStatus = ACCESS_CHECK_PENDING

services/web/frontend/js/shared/components/controlled-dropdown.tsx

@@ -40,12 +40,12 @@ const ControlledDropdown: FC<ControlledDropdownProps> = ({
 
         // Dropdown.Menu
         if ('open' in child.props) {
-          return cloneElement(child, { open: dropdownProps.open })
+          return cloneElement<any>(child, { open: dropdownProps.open })
         }
 
         // Overlay
         if ('show' in child.props) {
-          return cloneElement(child, { show: dropdownProps.open })
+          return cloneElement<any>(child, { show: dropdownProps.open })
         }
 
         // anything else

services/web/package.json

@@ -139,7 +139,7 @@
     "bowser": "^2.11.0",
     "bull": "^3.18.0",
     "bunyan": "^1.8.15",
-    "cache-flow": "^1.7.4",
+    "cache-flow": "^1.9.0",
     "celebrate": "^10.0.1",
     "chart.js": "^4.0.1",
     "chartjs-adapter-moment": "^1.0.1",
@@ -339,7 +339,7 @@
     "timekeeper": "^2.2.0",
     "to-string-loader": "^1.2.0",
     "tough-cookie": "^4.0.0",
-    "typescript": "^4.5.5",
+    "typescript": "^5.0.4",
     "val-loader": "^5.0.1",
     "webpack": "^5.83.1",
     "webpack-assets-manifest": "^5.1.0",

services/web/test/frontend/features/source-editor/helpers/active-editor-line.ts

@@ -17,8 +17,9 @@ export const activeEditorLine = () => {
     }
 
     // use the parent element if this is a node, e.g. text
-    const activeElement =
+    const activeElement = (
       'closest' in activeNode ? activeNode : activeNode.parentElement
+    ) as HTMLElement | undefined
 
     return cy.wrap(activeElement?.closest('.cm-line'))
   })

services/web/tsconfig.json

@@ -22,5 +22,6 @@
     "modules/**/stories/**/*.*",
     "cypress",
     "types"
-  ]
+  ],
+  "exclude": ["**/*.min.js"]
 }