Merge pull request #9792 from overleaf/ds-jpa-remove-stoponfirsterror-split-test

Split Test removal - removed stop-on-first-error split test code

GitOrigin-RevId: 4a5663397d0a967e0fa957453b36d466aa530630
This commit is contained in:
Tim Down
2022-10-03 16:22:13 +01:00
committed by Copybot
parent ff83838359
commit 53e517eea3
8 changed files with 82 additions and 158 deletions
@@ -932,21 +932,6 @@ const ProjectController = {
}
)
},
stopOnFirstErrorAssignment(cb) {
SplitTestHandler.getAssignment(
req,
res,
'stop-on-first-error',
(error, assignment) => {
// do not fail editor load if assignment fails
if (error) {
cb(null, { variant: 'default' })
} else {
cb(null, assignment)
}
}
)
},
interstitialPaymentFromPaywallAssignment(cb) {
SplitTestHandler.getAssignment(
req,
@@ -1072,7 +1057,6 @@ const ProjectController = {
newSourceEditorAssignment,
pdfjsAssignment,
dictionaryEditorAssignment,
stopOnFirstErrorAssignment,
}
) => {
if (err != null) {
@@ -1179,9 +1163,6 @@ const ProjectController = {
!userIsMemberOfGroupSubscription &&
!userHasInstitutionLicence
const showStopOnFirstError =
stopOnFirstErrorAssignment.variant === 'enabled'
const template =
detachRole === 'detached'
? 'project/editor_detached'
@@ -1252,7 +1233,6 @@ const ProjectController = {
showSymbolPalette,
galileoEnabled,
galileoFeatures,
showStopOnFirstError,
detachRole,
metadata: { viewport: false },
showUpgradePrompt,