Merge pull request #11158 from overleaf/em-recompile-pdf-split-test

Recompile PDF split test

GitOrigin-RevId: b02b3fb5b7a979ac299358e276ed432d736c7a03
This commit is contained in:
Eric Mc Sween
2023-01-16 09:37:00 -05:00
committed by Copybot
parent 778aa45e96
commit 56726053e8
2 changed files with 52 additions and 3 deletions

View File

@@ -48,6 +48,10 @@ const ProjectListController = require('./ProjectListController')
const ProjectAuditLogHandler = require('./ProjectAuditLogHandler')
const PublicAccessLevels = require('../Authorization/PublicAccessLevels')
// We want the recompile-button-text split test to only target users who have
// signed up recently.
const RECOMPILE_BUTTON_SPLIT_TEST_MIN_SIGNUP_DATE = new Date('2023-01-16')
/**
* @typedef {import("./types").GetProjectsRequest} GetProjectsRequest
* @typedef {import("./types").GetProjectsResponse} GetProjectsResponse
@@ -1082,6 +1086,27 @@ const ProjectController = {
}
)
},
recompileButtonTextAssignment: [
'user',
(results, cb) => {
if (
results.user.signUpDate <
RECOMPILE_BUTTON_SPLIT_TEST_MIN_SIGNUP_DATE
) {
return cb()
}
SplitTestHandler.getAssignment(
req,
res,
'recompile-button-text',
{},
() => {
// do not fail editor load if assignment fails
cb()
}
)
},
],
},
(
err,