diff --git a/libraries/object-persistor/package-lock.json b/libraries/object-persistor/package-lock.json index 480acc1756..a2cfc9c742 100644 --- a/libraries/object-persistor/package-lock.json +++ b/libraries/object-persistor/package-lock.json @@ -1,6 +1,6 @@ { "name": "@overleaf/object-persistor", - "version": "1.0.0", + "version": "1.0.1", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/libraries/object-persistor/package.json b/libraries/object-persistor/package.json index 12b1e8e39f..bfa8323e56 100644 --- a/libraries/object-persistor/package.json +++ b/libraries/object-persistor/package.json @@ -1,6 +1,6 @@ { "name": "@overleaf/object-persistor", - "version": "1.0.0", + "version": "1.0.1", "description": "Module for storing objects in multiple backends, with fallback on 404 to assist migration between them", "main": "index.js", "scripts": { diff --git a/libraries/object-persistor/src/GcsPersistor.js b/libraries/object-persistor/src/GcsPersistor.js index e8181c7e62..bc9ed1772e 100644 --- a/libraries/object-persistor/src/GcsPersistor.js +++ b/libraries/object-persistor/src/GcsPersistor.js @@ -200,15 +200,12 @@ module.exports = class GcsPersistor extends AbstractPersistor { if (this.settings.unlockBeforeDelete) { await file.setMetadata({ eventBasedHold: false }) } - try { - await file.delete() - } catch (err) { - // ignore 404s: it's fine if the file doesn't exist. - if (err.code !== 404) { - throw err - } - } + await file.delete() } catch (err) { + // ignore 404s: it's fine if the file doesn't exist. + if (err.code === 404) { + return + } throw PersistorHelper.wrapError( err, 'error deleting GCS object',